feat(Attribute): import methods for a single attribute#1279
Merged
BotellaA merged 2 commits intoJun 2, 2026
Conversation
BotellaA
reviewed
May 29, 2026
| } | ||
| } | ||
|
|
||
| void import( const AttributeManager::Impl &attribute_manager, |
Member
There was a problem hiding this comment.
could you reuse this code to import all attributes? I think there are code duplication here
Contributor
Author
There was a problem hiding this comment.
Sharing code for import all vs import one is not that simple, because of exception handling. But factorization is possible between the two import-all and import-one versions.
BotellaA
merged commit 39c45fb
into
Geode-solutions:import-one-attribute
5 of 6 checks passed
Member
|
🎉 This PR is included in version 17.1.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
Author
|
Thanks @BotellaA |
Member
|
🎉 This PR is included in version 17.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.