Skip to content

fix(Plane): add point on plane query#1293

Merged
BotellaA merged 5 commits into
nextfrom
fix/point-on-plane
Jun 24, 2026
Merged

fix(Plane): add point on plane query#1293
BotellaA merged 5 commits into
nextfrom
fix/point-on-plane

Conversation

@BotellaA

Copy link
Copy Markdown
Member

No description provided.

@BotellaA BotellaA requested a review from panquez June 23, 2026 14:56
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 3 concern(s)
  • include/geode/geometry/basic_objects/plane.hpp:89:9: warning: [google-explicit-constructor]

    single-argument constructors must be marked explicit to avoid unintentional implicit conversions

       89 |         Plane( const OwnerPlane& other );
          |         ^
          |         explicit 
  • src/geode/geometry/basic_objects/plane.cpp:38:20: warning: [bugprone-unchecked-optional-access]

    unchecked access to optional value

       38 |         : normal_( triangle.normal().value() ),
          |                    ^
  • src/geode/geometry/basic_objects/plane.cpp:106:25: warning: [hicpp-move-const-arg]

    std::move of the variable 'origin' of the trivially-copyable type 'Point3D' (aka 'Point<3>') has no effect; remove std::move()

      106 |         : Base( normal, std::move( origin ) )
          |                         ^~~~~~~~~~        ~

Have any feedback or feature suggestions? Share it here.

Comment thread src/geode/geometry/basic_objects/plane.cpp Outdated
@BotellaA BotellaA requested a review from panquez June 24, 2026 07:23
Comment thread src/geode/geometry/basic_objects/plane.cpp
@BotellaA BotellaA merged commit 35f29c1 into next Jun 24, 2026
20 checks passed
@BotellaA BotellaA deleted the fix/point-on-plane branch June 24, 2026 08:01
@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 17.3.4-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 17.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants