fix(Model): Added api functions to use and define internal relations … by MelchiorSchuh · Pull Request #1294 · Geode-solutions/OpenGeode

MelchiorSchuh · 2026-06-24T11:18:58Z

…between corners and closed lines

github-actions · 2026-06-24T11:30:50Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 274 concern(s)

bindings/python/src/model/representation/builder/brep_builder.cpp:40:10: warning: [misc-use-internal-linkage]

function 'define_brep_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   40 |     void define_brep_builder( pybind11::module& module )
      |          ^
      |     static 
```
bindings/python/src/model/representation/builder/section_builder.cpp:38:10: warning: [misc-use-internal-linkage]

function 'define_section_builder' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   38 |     void define_section_builder( pybind11::module& module )
      |          ^
      |     static 
```
bindings/python/src/model/representation/core/brep.cpp:41:10: warning: [misc-use-internal-linkage]

function 'define_brep' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   41 |     void define_brep( pybind11::module& module )
      |          ^
      |     static 
```
bindings/python/src/model/representation/core/section.cpp:39:10: warning: [misc-use-internal-linkage]

function 'define_section' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   39 |     void define_section( pybind11::module& module )
      |          ^
      |     static 
```
include/geode/model/representation/builder/brep_builder.hpp:91:31: warning: [cppcoreguidelines-special-member-functions]

class 'BRepBuilder' defines a copy constructor, a copy assignment operator and a move constructor but does not define a destructor or a move assignment operator
```
   91 |     class opengeode_model_api BRepBuilder : public TopologyBuilder,
      |                               ^
```
include/geode/model/representation/builder/section_builder.hpp:81:31: warning: [cppcoreguidelines-special-member-functions]

class 'SectionBuilder' defines a copy constructor, a copy assignment operator and a move constructor but does not define a destructor or a move assignment operator
```
   81 |     class opengeode_model_api SectionBuilder
      |                               ^
```
include/geode/model/representation/core/brep.hpp:75:31: warning: [cppcoreguidelines-special-member-functions]

class 'BRep' defines a destructor, a move constructor and a move assignment operator but does not define a copy constructor or a copy assignment operator
```
   75 |     class opengeode_model_api BRep : public Topology,
      |                               ^
```
include/geode/model/representation/core/brep.hpp:99:35: warning: [cppcoreguidelines-special-member-functions]

class 'BoundaryCornerRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
   99 |         class opengeode_model_api BoundaryCornerRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:117:35: warning: [cppcoreguidelines-special-member-functions]

class 'BoundaryLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  117 |         class opengeode_model_api BoundaryLineRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:135:35: warning: [cppcoreguidelines-special-member-functions]

class 'BoundarySurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  135 |         class opengeode_model_api BoundarySurfaceRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:153:35: warning: [cppcoreguidelines-special-member-functions]

class 'IncidentLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  153 |         class opengeode_model_api IncidentLineRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:171:35: warning: [cppcoreguidelines-special-member-functions]

class 'IncidentSurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  171 |         class opengeode_model_api IncidentSurfaceRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:189:35: warning: [cppcoreguidelines-special-member-functions]

class 'IncidentBlockRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  189 |         class opengeode_model_api IncidentBlockRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:207:35: warning: [cppcoreguidelines-special-member-functions]

class 'InternalCornerRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  207 |         class opengeode_model_api InternalCornerRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:229:35: warning: [cppcoreguidelines-special-member-functions]

class 'InternalLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  229 |         class opengeode_model_api InternalLineRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:250:35: warning: [cppcoreguidelines-special-member-functions]

class 'InternalSurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  250 |         class opengeode_model_api InternalSurfaceRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:270:35: warning: [cppcoreguidelines-special-member-functions]

class 'EmbeddingLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  270 |         class opengeode_model_api EmbeddingLineRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:290:35: warning: [cppcoreguidelines-special-member-functions]

class 'EmbeddingSurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  290 |         class opengeode_model_api EmbeddingSurfaceRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:311:35: warning: [cppcoreguidelines-special-member-functions]

class 'EmbeddingBlockRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  311 |         class opengeode_model_api EmbeddingBlockRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:333:35: warning: [cppcoreguidelines-special-member-functions]

class 'ItemCornerRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  333 |         class opengeode_model_api ItemCornerRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:352:35: warning: [cppcoreguidelines-special-member-functions]

class 'ItemLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  352 |         class opengeode_model_api ItemLineRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:370:35: warning: [cppcoreguidelines-special-member-functions]

class 'ItemSurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  370 |         class opengeode_model_api ItemSurfaceRange
      |                                   ^
```
include/geode/model/representation/core/brep.hpp:391:35: warning: [cppcoreguidelines-special-member-functions]

class 'ItemBlockRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  391 |         class opengeode_model_api ItemBlockRange
      |                                   ^
```

include/geode/model/representation/core/brep.hpp:413:15: warning: [cppcoreguidelines-noexcept-move-operations]

move assignment operators should be marked noexcept

  413 |         BRep& operator=( BRep&& brep );
      |               ^                       
      |                                        noexcept

include/geode/model/representation/core/brep.hpp:573:20: warning: [llvm-qualified-auto]

'const auto extension' can be declared as 'const auto *const extension'

  573 |             static const auto extension = "og_brep";
      |                    ^~~~~~~~~~
      |                    const auto *const

include/geode/model/representation/core/section.hpp:71:31: warning: [cppcoreguidelines-special-member-functions]

class 'Section' defines a destructor, a move constructor and a move assignment operator but does not define a copy constructor or a copy assignment operator
```
   71 |     class opengeode_model_api Section : public Topology,
      |                               ^
```
include/geode/model/representation/core/section.hpp:91:35: warning: [cppcoreguidelines-special-member-functions]

class 'BoundaryCornerRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
   91 |         class opengeode_model_api BoundaryCornerRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:109:35: warning: [cppcoreguidelines-special-member-functions]

class 'BoundaryLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  109 |         class opengeode_model_api BoundaryLineRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:128:35: warning: [cppcoreguidelines-special-member-functions]

class 'IncidentLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  128 |         class opengeode_model_api IncidentLineRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:146:35: warning: [cppcoreguidelines-special-member-functions]

class 'IncidentSurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  146 |         class opengeode_model_api IncidentSurfaceRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:164:35: warning: [cppcoreguidelines-special-member-functions]

class 'InternalLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  164 |         class opengeode_model_api InternalLineRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:185:35: warning: [cppcoreguidelines-special-member-functions]

class 'InternalCornerRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  185 |         class opengeode_model_api InternalCornerRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:207:35: warning: [cppcoreguidelines-special-member-functions]

class 'EmbeddingLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  207 |         class opengeode_model_api EmbeddingLineRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:228:35: warning: [cppcoreguidelines-special-member-functions]

class 'EmbeddingSurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  228 |         class opengeode_model_api EmbeddingSurfaceRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:250:35: warning: [cppcoreguidelines-special-member-functions]

class 'ItemCornerRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  250 |         class opengeode_model_api ItemCornerRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:269:35: warning: [cppcoreguidelines-special-member-functions]

class 'ItemLineRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  269 |         class opengeode_model_api ItemLineRange
      |                                   ^
```
include/geode/model/representation/core/section.hpp:290:35: warning: [cppcoreguidelines-special-member-functions]

class 'ItemSurfaceRange' defines a destructor and a copy constructor but does not define a copy assignment operator, a move constructor or a move assignment operator
```
  290 |         class opengeode_model_api ItemSurfaceRange
      |                                   ^
```

include/geode/model/representation/core/section.hpp:312:18: warning: [cppcoreguidelines-noexcept-move-operations]

move assignment operators should be marked noexcept

  312 |         Section& operator=( Section&& section );
      |                  ^                             
      |                                                 noexcept

include/geode/model/representation/core/section.hpp:317:65: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters

  317 |         [[nodiscard]] const Component2D& component( const uuid& id ) const;
      |                                                                 ^

include/geode/model/representation/core/section.hpp:412:20: warning: [llvm-qualified-auto]

'const auto extension' can be declared as 'const auto *const extension'

  412 |             static const auto extension = "og_sctn";
      |                    ^~~~~~~~~~
      |                    const auto *const

src/geode/model/representation/builder/brep_builder.cpp:80:24: warning: [performance-unnecessary-copy-initialization]

the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference
```
   80 |         if( const auto name = brep.name() )
      |                        ^
      |                       &
```
src/geode/model/representation/builder/brep_builder.cpp:163:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  163 |         const auto& id = create_corner();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:170:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  170 |         const auto& id = create_corner( impl );
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:177:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  177 |         const auto& id = create_line();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:184:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  184 |         const auto& id = create_line( impl );
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:191:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  191 |         const auto& id = create_surface();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:198:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  198 |         const auto& id = create_surface( impl );
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:205:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  205 |         const auto& id = create_block();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:212:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  212 |         const auto& id = create_block( impl );
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:219:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  219 |         const auto& id = create_model_boundary();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:226:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  226 |         const auto& id = create_corner_collection();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:234:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  234 |         const auto& id = create_line_collection();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:241:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  241 |         const auto& id = create_surface_collection();
      |                     ^
```
src/geode/model/representation/builder/brep_builder.cpp:249:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  249 |         const auto& id = create_block_collection();
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:74:24: warning: [performance-unnecessary-copy-initialization]

the const qualified variable 'name' is copy-constructed from a const reference; consider making it a const reference
```
   74 |         if( const auto name = section.name() )
      |                        ^
      |                       &
```
src/geode/model/representation/builder/section_builder.cpp:147:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  147 |         const auto& id = create_corner();
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:154:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  154 |         const auto& id = create_corner( impl );
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:161:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  161 |         const auto& id = create_line();
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:168:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  168 |         const auto& id = create_line( impl );
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:175:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  175 |         const auto& id = create_surface();
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:182:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  182 |         const auto& id = create_surface( impl );
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:189:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  189 |         const auto& id = create_model_boundary();
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:197:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  197 |         const auto& id = create_corner_collection();
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:205:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  205 |         const auto& id = create_line_collection();
      |                     ^
```
src/geode/model/representation/builder/section_builder.cpp:213:21: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  213 |         const auto& id = create_surface_collection();
      |                     ^
```

src/geode/model/representation/core/brep.cpp:63:32: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

   63 |     BRep::BoundaryCornerRange::BoundaryCornerRange(
      |                                ^
   64 |         const BoundaryCornerRange& range )
   65 |         : Relationships::BoundaryRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
   66 |     {
      |     ~
      |     = default;
   67 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:99:30: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

   99 |     BRep::BoundaryLineRange::BoundaryLineRange( const BoundaryLineRange& range )
      |                              ^
  100 |         : Relationships::BoundaryRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  101 |     {
      |     ~
      |     = default;
  102 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:134:33: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  134 |     BRep::BoundarySurfaceRange::BoundarySurfaceRange(
      |                                 ^
  135 |         const BoundarySurfaceRange& range )
  136 |         : Relationships::BoundaryRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  137 |     {
      |     ~
      |     = default;
  138 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:171:30: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  171 |     BRep::IncidentLineRange::IncidentLineRange( const IncidentLineRange& range )
      |                              ^
  172 |         : Relationships::IncidenceRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  173 |     {
      |     ~
      |     = default;
  174 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:206:33: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  206 |     BRep::IncidentSurfaceRange::IncidentSurfaceRange(
      |                                 ^
  207 |         const IncidentSurfaceRange& range )
  208 |         : Relationships::IncidenceRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  209 |     {
      |     ~
      |     = default;
  210 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:243:31: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  243 |     BRep::IncidentBlockRange::IncidentBlockRange(
      |                               ^
  244 |         const IncidentBlockRange& range )
  245 |         : Relationships::IncidenceRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  246 |     {
      |     ~
      |     = default;
  247 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:281:30: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  281 |     BRep::InternalLineRange::InternalLineRange( const InternalLineRange& range )
      |                              ^
  282 |         : Relationships::InternalRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  283 |     {
      |     ~
      |     = default;
  284 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:349:32: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  349 |     BRep::InternalCornerRange::InternalCornerRange(
      |                                ^
  350 |         const InternalCornerRange& range )
  351 |         : Relationships::InternalRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  352 |     {
      |     ~
      |     = default;
  353 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:407:33: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  407 |     BRep::InternalSurfaceRange::InternalSurfaceRange(
      |                                 ^
  408 |         const InternalSurfaceRange& range )
  409 |         : Relationships::InternalRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  410 |     {
      |     ~
      |     = default;
  411 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:452:31: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  452 |     BRep::EmbeddingLineRange::EmbeddingLineRange(
      |                               ^
  453 |         const EmbeddingLineRange& range )
  454 |         : Relationships::EmbeddingRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  455 |     {
      |     ~
      |     = default;
  456 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:496:34: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  496 |     BRep::EmbeddingSurfaceRange::EmbeddingSurfaceRange(
      |                                  ^
  497 |         const EmbeddingSurfaceRange& range )
  498 |         : Relationships::EmbeddingRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  499 |     {
      |     ~
      |     = default;
  500 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:569:32: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  569 |     BRep::EmbeddingBlockRange::EmbeddingBlockRange(
      |                                ^
  570 |         const EmbeddingBlockRange& range )
  571 |         : Relationships::EmbeddingRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  572 |     {
      |     ~
      |     = default;
  573 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:620:28: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  620 |     BRep::ItemCornerRange::ItemCornerRange( const ItemCornerRange& range )
      |                            ^
  621 |         : Relationships::ItemRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  622 |     {
      |     ~
      |     = default;
  623 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:650:26: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  650 |     BRep::ItemLineRange::ItemLineRange( const ItemLineRange& range )
      |                          ^
  651 |         : Relationships::ItemRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  652 |     {
      |     ~
      |     = default;
  653 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:685:29: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  685 |     BRep::ItemSurfaceRange::ItemSurfaceRange( const ItemSurfaceRange& range )
      |                             ^
  686 |         : Relationships::ItemRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  687 |     {
      |     ~
      |     = default;
  688 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:715:27: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  715 |     BRep::ItemBlockRange::ItemBlockRange( const ItemBlockRange& range )
      |                           ^
  716 |         : Relationships::ItemRangeIterator{ range }, brep_( range.brep_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~
  717 |     {
      |     ~
      |     = default;
  718 |     }
      |     ~

src/geode/model/representation/core/brep.cpp:742:33: warning: [bugprone-use-after-move]

'brep' used after it was moved

  742 |           Corners3D{ std::move( brep ) },
      |                                 ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:743:31: warning: [bugprone-use-after-move]

'brep' used after it was moved

  743 |           Lines3D{ std::move( brep ) },
      |                               ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:744:34: warning: [bugprone-use-after-move]

'brep' used after it was moved

  744 |           Surfaces3D{ std::move( brep ) },
      |                                  ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:745:32: warning: [bugprone-use-after-move]

'brep' used after it was moved

  745 |           Blocks3D{ std::move( brep ) },
      |                                ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:746:41: warning: [bugprone-use-after-move]

'brep' used after it was moved

  746 |           ModelBoundaries3D{ std::move( brep ) },
      |                                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:747:43: warning: [bugprone-use-after-move]

'brep' used after it was moved

  747 |           CornerCollections3D{ std::move( brep ) },
      |                                           ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:748:41: warning: [bugprone-use-after-move]

'brep' used after it was moved

  748 |           LineCollections3D{ std::move( brep ) },
      |                                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:749:44: warning: [bugprone-use-after-move]

'brep' used after it was moved

  749 |           SurfaceCollections3D{ std::move( brep ) },
      |                                            ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:750:42: warning: [bugprone-use-after-move]

'brep' used after it was moved

  750 |           BlockCollections3D{ std::move( brep ) },
      |                                          ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:751:34: warning: [bugprone-use-after-move]

'brep' used after it was moved

  751 |           Identifier{ std::move( brep ) }
      |                                  ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:741:11: note: move occurred here
  741 |         : Topology{ std::move( brep ) },
      |           ^

src/geode/model/representation/core/brep.cpp:755:17: warning: [cppcoreguidelines-noexcept-move-operations]

move assignment operators should be marked noexcept
```
  755 |     BRep& BRep::operator=( BRep&& brep )
      |                 ^
  756 |     {
      |  noexcept 
```

src/geode/model/representation/core/brep.cpp:758:42: warning: [bugprone-use-after-move]

'brep' used after it was moved

  758 |         Corners3D::operator=( std::move( brep ) );
      |                                          ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:757:19: note: move occurred here
  757 |         Topology::operator=( std::move( brep ) );
      |                   ^

src/geode/model/representation/core/brep.cpp:759:40: warning: [bugprone-use-after-move]

'brep' used after it was moved

  759 |         Lines3D::operator=( std::move( brep ) );
      |                                        ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:758:20: note: move occurred here
  758 |         Corners3D::operator=( std::move( brep ) );
      |                    ^

src/geode/model/representation/core/brep.cpp:760:43: warning: [bugprone-use-after-move]

'brep' used after it was moved

  760 |         Surfaces3D::operator=( std::move( brep ) );
      |                                           ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:759:18: note: move occurred here
  759 |         Lines3D::operator=( std::move( brep ) );
      |                  ^

src/geode/model/representation/core/brep.cpp:761:41: warning: [bugprone-use-after-move]

'brep' used after it was moved

  761 |         Blocks3D::operator=( std::move( brep ) );
      |                                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:760:21: note: move occurred here
  760 |         Surfaces3D::operator=( std::move( brep ) );
      |                     ^

src/geode/model/representation/core/brep.cpp:762:50: warning: [bugprone-use-after-move]

'brep' used after it was moved

  762 |         ModelBoundaries3D::operator=( std::move( brep ) );
      |                                                  ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:761:19: note: move occurred here
  761 |         Blocks3D::operator=( std::move( brep ) );
      |                   ^

src/geode/model/representation/core/brep.cpp:763:52: warning: [bugprone-use-after-move]

'brep' used after it was moved

  763 |         CornerCollections3D::operator=( std::move( brep ) );
      |                                                    ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:762:28: note: move occurred here
  762 |         ModelBoundaries3D::operator=( std::move( brep ) );
      |                            ^

src/geode/model/representation/core/brep.cpp:764:50: warning: [bugprone-use-after-move]

'brep' used after it was moved

  764 |         LineCollections3D::operator=( std::move( brep ) );
      |                                                  ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:763:30: note: move occurred here
  763 |         CornerCollections3D::operator=( std::move( brep ) );
      |                              ^

src/geode/model/representation/core/brep.cpp:765:53: warning: [bugprone-use-after-move]

'brep' used after it was moved

  765 |         SurfaceCollections3D::operator=( std::move( brep ) );
      |                                                     ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:764:28: note: move occurred here
  764 |         LineCollections3D::operator=( std::move( brep ) );
      |                            ^

src/geode/model/representation/core/brep.cpp:766:51: warning: [bugprone-use-after-move]

'brep' used after it was moved

  766 |         BlockCollections3D::operator=( std::move( brep ) );
      |                                                   ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:765:31: note: move occurred here
  765 |         SurfaceCollections3D::operator=( std::move( brep ) );
      |                               ^

src/geode/model/representation/core/brep.cpp:767:43: warning: [bugprone-use-after-move]

'brep' used after it was moved

  767 |         Identifier::operator=( std::move( brep ) );
      |                                           ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/brep.cpp:766:29: note: move occurred here
  766 |         BlockCollections3D::operator=( std::move( brep ) );
      |                             ^

src/geode/model/representation/core/section.cpp:61:35: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

   61 |     Section::BoundaryCornerRange::BoundaryCornerRange(
      |                                   ^
   62 |         const BoundaryCornerRange& range )
   63 |         : Relationships::BoundaryRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   64 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
   65 |     {
      |     ~
      |     = default;
   66 |     }
      |     ~

src/geode/model/representation/core/section.cpp:100:33: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  100 |     Section::BoundaryLineRange::BoundaryLineRange(
      |                                 ^
  101 |         const BoundaryLineRange& range )
  102 |         : Relationships::BoundaryRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  103 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
  104 |     {
      |     ~
      |     = default;
  105 |     }
      |     ~

src/geode/model/representation/core/section.cpp:138:33: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  138 |     Section::IncidentLineRange::IncidentLineRange(
      |                                 ^
  139 |         const IncidentLineRange& range )
  140 |         : Relationships::IncidenceRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  141 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
  142 |     {
      |     ~
      |     = default;
  143 |     }
      |     ~

src/geode/model/representation/core/section.cpp:176:36: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  176 |     Section::IncidentSurfaceRange::IncidentSurfaceRange(
      |                                    ^
  177 |         const IncidentSurfaceRange& range )
  178 |         : Relationships::IncidenceRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  179 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
  180 |     {
      |     ~
      |     = default;
  181 |     }
      |     ~

src/geode/model/representation/core/section.cpp:217:33: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  217 |     Section::InternalLineRange::InternalLineRange(
      |                                 ^
  218 |         const InternalLineRange& range )
  219 |         : Relationships::InternalRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  220 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
  221 |     {
      |     ~
      |     = default;
  222 |     }
      |     ~

src/geode/model/representation/core/section.cpp:276:35: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  276 |     Section::InternalCornerRange::InternalCornerRange(
      |                                   ^
  277 |         const InternalCornerRange& range )
  278 |         : Relationships::InternalRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  279 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
  280 |     {
      |     ~
      |     = default;
  281 |     }
      |     ~

src/geode/model/representation/core/section.cpp:322:34: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  322 |     Section::EmbeddingLineRange::EmbeddingLineRange(
      |                                  ^
  323 |         const EmbeddingLineRange& range )
  324 |         : Relationships::EmbeddingRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  325 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
  326 |     {
      |     ~
      |     = default;
  327 |     }
      |     ~

src/geode/model/representation/core/section.cpp:381:37: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  381 |     Section::EmbeddingSurfaceRange::EmbeddingSurfaceRange(
      |                                     ^
  382 |         const EmbeddingSurfaceRange& range )
  383 |         : Relationships::EmbeddingRangeIterator{ range },
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  384 |           section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~
  385 |     {
      |     ~
      |     = default;
  386 |     }
      |     ~

src/geode/model/representation/core/section.cpp:421:31: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  421 |     Section::ItemCornerRange::ItemCornerRange( const ItemCornerRange& range )
      |                               ^
  422 |         : Relationships::ItemRangeIterator{ range }, section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~~~~~~~
  423 |     {
      |     ~
      |     = default;
  424 |     }
      |     ~

src/geode/model/representation/core/section.cpp:458:29: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  458 |     Section::ItemLineRange::ItemLineRange( const ItemLineRange& range )
      |                             ^
  459 |         : Relationships::ItemRangeIterator{ range }, section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~~~~~~~
  460 |     {
      |     ~
      |     = default;
  461 |     }
      |     ~

src/geode/model/representation/core/section.cpp:488:32: warning: [hicpp-use-equals-default]

use '= default' to define a trivial copy constructor

  488 |     Section::ItemSurfaceRange::ItemSurfaceRange( const ItemSurfaceRange& range )
      |                                ^
  489 |         : Relationships::ItemRangeIterator{ range }, section_( range.section_ )
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~~~~~~~~~~~~~~~
  490 |     {
      |     ~
      |     = default;
  491 |     }
      |     ~

src/geode/model/representation/core/section.cpp:515:33: warning: [bugprone-use-after-move]

'section' used after it was moved

  515 |           Corners2D{ std::move( section ) },
      |                                 ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:516:31: warning: [bugprone-use-after-move]

'section' used after it was moved

  516 |           Lines2D{ std::move( section ) },
      |                               ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:517:34: warning: [bugprone-use-after-move]

'section' used after it was moved

  517 |           Surfaces2D{ std::move( section ) },
      |                                  ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:518:41: warning: [bugprone-use-after-move]

'section' used after it was moved

  518 |           ModelBoundaries2D{ std::move( section ) },
      |                                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:519:43: warning: [bugprone-use-after-move]

'section' used after it was moved

  519 |           CornerCollections2D{ std::move( section ) },
      |                                           ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:520:41: warning: [bugprone-use-after-move]

'section' used after it was moved

  520 |           LineCollections2D{ std::move( section ) },
      |                                         ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:521:44: warning: [bugprone-use-after-move]

'section' used after it was moved

  521 |           SurfaceCollections2D{ std::move( section ) },
      |                                            ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:522:34: warning: [bugprone-use-after-move]

'section' used after it was moved

  522 |           Identifier{ std::move( section ) }
      |                                  ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:514:11: note: move occurred here
  514 |         : Topology{ std::move( section ) },
      |           ^

src/geode/model/representation/core/section.cpp:526:23: warning: [cppcoreguidelines-noexcept-move-operations]

move assignment operators should be marked noexcept
```
  526 |     Section& Section::operator=( Section&& section )
      |                       ^
  527 |     {
      |  noexcept 
```

src/geode/model/representation/core/section.cpp:529:42: warning: [bugprone-use-after-move]

'section' used after it was moved

  529 |         Corners2D::operator=( std::move( section ) );
      |                                          ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:528:19: note: move occurred here
  528 |         Topology::operator=( std::move( section ) );
      |                   ^

src/geode/model/representation/core/section.cpp:530:40: warning: [bugprone-use-after-move]

'section' used after it was moved

  530 |         Lines2D::operator=( std::move( section ) );
      |                                        ^
/__w/OpenGeode/OpenGeode/src/geode/model/representation/core/section.cpp:529:20: note: move occurred here
  529 |         Corners2D::operator=( std::move( section ) );
      |                    ^

Have any feedback or feature suggestions? Share it here.

BotellaA

do we need to upgrade the tests ?

…line_internal_corner_check

fix(Model): Added api functions to use and define internal relations …

7716920

…between corners and closed lines

MelchiorSchuh requested a review from BotellaA June 24, 2026 11:18

BotellaA approved these changes Jun 24, 2026

View reviewed changes

MelchiorSchuh added 2 commits June 24, 2026 15:30

added tests

88e64d9

Merge branch 'next' of github.com:Geode-solutions/OpenGeode into fix/…

6bb0b33

…line_internal_corner_check

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(Model): Added api functions to use and define internal relations …#1294

fix(Model): Added api functions to use and define internal relations …#1294
MelchiorSchuh wants to merge 3 commits into
nextfrom
fix/line_internal_corner_check

MelchiorSchuh commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026 •

edited

Loading

Uh oh!

BotellaA left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

MelchiorSchuh commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

BotellaA left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 24, 2026 •

edited

Loading