Skip to content

Drop dead databinding ignore and add benchmark to apiValidation#6432

Merged
andremion merged 1 commit into
developfrom
chore/api-validation-cleanup
May 11, 2026
Merged

Drop dead databinding ignore and add benchmark to apiValidation#6432
andremion merged 1 commit into
developfrom
chore/api-validation-cleanup

Conversation

@andremion
Copy link
Copy Markdown
Contributor

@andremion andremion commented May 11, 2026

Goal

Bring the root apiValidation block in line with the current module layout: drop a dead entry and close one gap so the list is the single source of truth for "what we don't validate."

Implementation

  • Remove com/getstream/sdk/chat/databinding from ignoredPackages — the com.getstream.sdk namespace no longer exists anywhere in the repo.
  • Add stream-chat-android-benchmark to ignoredProjects — it was the only non-validated module missing from the list.

No public API surface changes; ./gradlew apiCheck passes with no .api regeneration needed.

Testing

  1. Run ./gradlew apiCheck — should succeed.
  2. Run ./gradlew apiCheck --dry-runapiCheck tasks should run for the 6 published library modules (client, compose, core, markdown-transformer, ui-common, ui-components) and no others.

Summary by CodeRabbit

  • Chores
    • Updated build configuration for API validation and benchmark module exclusions.

Review Change Stack

- Remove `com/getstream/sdk/chat/databinding` from ignoredPackages —
  the `com.getstream.sdk` namespace no longer exists in the repo.
- Add `stream-chat-android-benchmark` to ignoredProjects so the list
  enumerates every non-validated module.
@andremion andremion added the pr:internal Internal changes / housekeeping label May 11, 2026
@andremion andremion requested a review from a team as a code owner May 11, 2026 12:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled (or ignored for dependabot PRs).

🎉 Great job! This PR is ready for review.

@andremion andremion changed the title Clean up apiValidation config Drop dead databinding ignore and add benchmark to apiValidation May 11, 2026
@andremion andremion enabled auto-merge (squash) May 11, 2026 12:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5a4df865-231b-4bca-b9b6-15834535be28

📥 Commits

Reviewing files that changed from the base of the PR and between 8891e22 and 672c6a5.

📒 Files selected for processing (1)
  • build.gradle.kts

Walkthrough

The PR updates build.gradle.kts apiValidation configuration. It removes the deprecated com/getstream/sdk/chat/databinding ignored package while retaining io/getstream/chat/android/ui/databinding. The stream-chat-android-benchmark module is added to the ignored projects list.

Changes

Build Configuration

Layer / File(s) Summary
API Validation Configuration
build.gradle.kts
Ignored package path updated: com/getstream/sdk/chat/databinding removed, io/getstream/chat/android/ui/databinding retained. stream-chat-android-benchmark added to ignored projects.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Two little tweaks in the gradle file,
Old paths removed with a hoppy smile,
Benchmark bounces to the exclusion zone,
Build config cleanup—a build this rabbit condones! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: removing a dead databinding ignore entry and adding the benchmark module to apiValidation exclusions.
Description check ✅ Passed The description covers the required sections (Goal, Implementation, Testing) with clear details, though UI Changes and Contributor Checklist sections are appropriately omitted as they don't apply to this configuration-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/api-validation-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.82 MB 5.82 MB 0.00 MB 🟢
stream-chat-android-ui-components 11.02 MB 11.02 MB 0.00 MB 🟢
stream-chat-android-compose 12.39 MB 12.39 MB 0.00 MB 🟢

@andremion andremion merged commit 1965ffe into develop May 11, 2026
16 of 19 checks passed
@andremion andremion deleted the chore/api-validation-cleanup branch May 11, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:internal Internal changes / housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants