Drop dead databinding ignore and add benchmark to apiValidation#6432
Conversation
- Remove `com/getstream/sdk/chat/databinding` from ignoredPackages — the `com.getstream.sdk` namespace no longer exists in the repo. - Add `stream-chat-android-benchmark` to ignoredProjects so the list enumerates every non-validated module.
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR updates ChangesBuild Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
SDK Size Comparison 📏
|



Goal
Bring the root
apiValidationblock in line with the current module layout: drop a dead entry and close one gap so the list is the single source of truth for "what we don't validate."Implementation
com/getstream/sdk/chat/databindingfromignoredPackages— thecom.getstream.sdknamespace no longer exists anywhere in the repo.stream-chat-android-benchmarktoignoredProjects— it was the only non-validated module missing from the list.No public API surface changes;
./gradlew apiCheckpasses with no.apiregeneration needed.Testing
./gradlew apiCheck— should succeed../gradlew apiCheck --dry-run—apiChecktasks should run for the 6 published library modules (client,compose,core,markdown-transformer,ui-common,ui-components) and no others.Summary by CodeRabbit