fix(llc): Fixed build in dart2wasm environment#2379
Open
ebraminio wants to merge 1 commit intoGetStream:masterfrom
Open
fix(llc): Fixed build in dart2wasm environment#2379ebraminio wants to merge 1 commit intoGetStream:masterfrom
ebraminio wants to merge 1 commit intoGetStream:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://dart.dev/interop/js-interop/past-js-interop we should now "prefer using dart:js_interop going forwards and migrate usages of old interop libraries when possible" and this change does that in order to make the library compatible with
--wasmbuilds.Submit a pull request
Linear: FLU-
Github Issue: #
CLA
--wasmon this project needs Avoid incorrect cast in sql_js in wasm builds simolus3/drift#3657 (already merged but not released) and Migrate to package:web Alberto-Monteiro/video_thumbnail#9 also but having all of them it's possible to make it in the CI also AFAICS.Description of the pull request
When I'm building example of this project in
flutter run -d chrome --wasmmode the web mode isn't recognized correctly and raises errors like this on the consoleWhich this change fixes
Summary by CodeRabbit
Bug Fixes
Refactor
Chores