fix: do not mask dial errors with KeyError - #567
Merged
Merged
Conversation
This was referenced Sep 18, 2026
Member
Author
|
Here's where we are in this PR Chain:
Group A (1–3) is independent of telemetry and could ship on its own; #568 carries the only user-visible breaking change. Group B (4–8) is inert because |
_remove_cached popped the instance's cache without a default, so a failed dial against static connection info raised KeyError over the top of the error that sent it there. The static connection info path builds its cache per connect and never stores it in self._cache, so the pop always misses. Tolerate the miss in both connectors. Only the synchronous Connector supports static connection info and can hit this today; AsyncConnector gets the same guard so the two cannot drift.
enocom
force-pushed
the
telemetry-2-remove-cached-keyerror
branch
from
September 19, 2026 03:26
f4c2d75 to
3b807a4
Compare
enocom
marked this pull request as ready for review
September 19, 2026 03:27
enocom
added this pull request to stack #577
September 19, 2026 04:15
rhatgadkar-goog
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_remove_cached popped the instance's cache without a default, so a failed
dial against static connection info raised KeyError over the top of the
error that sent it there. The static connection info path builds its
cache per connect and never stores it in self._cache, so the pop always
misses.
Tolerate the miss in both connectors. Only the synchronous Connector
supports static connection info and can hit this today; AsyncConnector
gets the same guard so the two cannot drift.
Related to #449