Skip to content

build: update release.sh to not use setup.py #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackwotherspoon merged 1 commit into from
Feb 12, 2025
Merged

build: update release.sh to not use setup.py #1236

jackwotherspoon merged 1 commit into from
Feb 12, 2025

Conversation

@jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Feb 12, 2025

In #1230 we moved package off of setup.py and over to pyproject.toml

Forgot a spot to update in release.sh which references setup.py which no longer exists.

Related to #1230

@jackwotherspoon jackwotherspoon self-assigned this Feb 12, 2025
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner February 12, 2025 19:51
kgala2
kgala2 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@kgala2 kgala2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackwotherspoon jackwotherspoon merged commit be2c770 into main Feb 12, 2025
15 checks passed
@jackwotherspoon jackwotherspoon deleted the jackwotherspoon-patch-1 branch February 12, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgala2 kgala2 kgala2 approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackwotherspoon @kgala2