Skip to content

Conversation

@SwarnaBharathiMantena
Copy link
Contributor

Hotfix v1.75.1 is for the release_channel and maintenance_exclusions end_time & end_time_behavior update.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SwarnaBharathiMantena, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This hotfix, "v1.75.1", addresses updates to GKE cluster configurations across various blueprints and modules. The primary changes involve standardizing the GKE "release_channel" to "REGULAR" and enhancing the "maintenance_exclusions" feature to support "exclusion_end_time_behavior". This allows users to define maintenance windows that last until the end of support for a given version, providing greater control over cluster updates. The update also includes necessary schema and validation changes in the "gke-cluster" Terraform module and a general version bump across all affected modules.

Highlights

  • Version Bump: The core application version and all associated Terraform modules have been updated from "v1.75.0" to "v1.75.1".
  • GKE Release Channel Update: GKE cluster configurations in example blueprints have been standardized to use the "REGULAR" release channel instead of "RAPID".
  • GKE Maintenance Exclusions Enhancement: The mechanism for defining GKE cluster maintenance exclusions has been updated to support "exclusion_end_time_behavior: UNTIL_END_OF_SUPPORT", allowing for more flexible and long-term exclusion configurations.
  • Terraform Module Updates: The "gke-cluster" Terraform module now includes "exclusion_end_time_behavior" in its "maintenance_exclusions" variable, along with new validation rules to enforce correct usage (either "end_time" or "exclusion_end_time_behavior" must be specified, and the latter must be "UNTIL_END_OF_SUPPORT").
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a hotfix that correctly implements support for exclusion_end_time_behavior in the gke-cluster module's maintenance exclusions. The changes are well-executed, including updates to the variable definition, robust validation, and documentation in the README. The accompanying updates to the example blueprints to use this new feature and bump the version across all modules are also correct and consistent. I have one suggestion to improve the clarity of validation error messages.

bytetwin
bytetwin previously approved these changes Dec 13, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena marked this pull request as ready for review December 14, 2025 03:41
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 3d8865c into main Dec 14, 2025
31 of 83 checks passed
@sudheer-quad sudheer-quad deleted the hotfix-v1.75.1 branch December 31, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants