securitycenter: add google_scc_notification_service_account - #18613
Open
c2thorn wants to merge 1 commit into
Open
securitycenter: add google_scc_notification_service_account#18613c2thorn wants to merge 1 commit into
c2thorn wants to merge 1 commit into
Conversation
Adds the google_scc_notification_service_account resource to retrieve the SCC notification service account email across organization and project scopes, preventing permission errors when configuring Pub/Sub IAM bindings ahead of NotificationConfig deployment. Fixes b/536845649 Signed-off-by: camthornton <camthornton@google.com>
c2thorn
force-pushed
the
scc-notification-service-account
branch
from
August 12, 2026 19:06
d6101bd to
61bd3b2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 61bd3b2: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log |
Member
Author
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
google_scc_notification_service_accountto provision the SCC notification service account and export its email/member string for Pub/Sub IAM bindings.Fixes b/536845649
Background
Creating an SCC notification config requires granting
roles/pubsub.publisherto the SCC notification service account on the destination topic. In fresh environments, this service account isn't provisioned yet, which causes initial Terraform applies to fail unless created out-of-band first.Generic
google_project_service_identitydoesn't work here becausesecuritycenter.googleapis.comuses multiple service agents and ServiceUsage doesn't return an email for the notification agent.Details
google_storage_project_service_accountandgoogle_access_approval_organization_service_account.:generateServiceIdentityto trigger IAM provisioning, then returns the deterministic email (service-org-...orservice-...).organizationandprojectscopes (folder-level configs in GCP use the org service account).Deleteis a no-op since managed service agents cannot be deleted.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.