Skip to content

tgc: update bigquery dataset fixtures for default_collation - #18616

Merged
c2thorn merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:fix-tgc-bigquery-dataset-fixtures-8.0.0
Aug 13, 2026
Merged

tgc: update bigquery dataset fixtures for default_collation#18616
c2thorn merged 2 commits into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:fix-tgc-bigquery-dataset-fixtures-8.0.0

Conversation

@c2thorn

@c2thorn c2thorn commented Aug 12, 2026

Copy link
Copy Markdown
Member

Update BigQuery dataset TGC test fixtures as a followup to #18585.

Because default_collation is no longer computed, TGC now includes "defaultCollation": "" in the asset output for unconfigured datasets.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a724cee:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 8 files changed, 8 insertions(+)

@c2thorn

c2thorn commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from SirGitsalot August 12, 2026 21:49
@c2thorn
c2thorn merged commit d248ca6 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0 Aug 13, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants