Add immutable attribute to TlsInspectionPolicy parameters - #18624
Open
JamesDuncanNz wants to merge 1 commit into
Open
Add immutable attribute to TlsInspectionPolicy parameters#18624JamesDuncanNz wants to merge 1 commit into
JamesDuncanNz wants to merge 1 commit into
Conversation
Added 'immutable' attribute to parameters in TlsInspectionPolicy.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 731d5f9: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @JamesDuncanNz, @ScottSuarez VCR tests complete for 731d5f9! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mark
nameandlocationparameters asimmutable: trueonTlsInspectionPolicy.Previously,
immutable: truewas missing on the URL parametersnameandlocationinmmv1/products/networksecurity/TlsInspectionPolicy.yaml. As a result, the generated Terraform schema did not haveForceNew: true, causing Terraform to erroneously plan an in-place update when either field was changed. During apply, this resulted in an invalidPATCHrequest to the new resource name/location endpoint and failed on subsequent state read with:Adding
immutable: trueensures Terraform correctly plans a destroy-and-recreate (ForceNew) whennameorlocationis changed.Release Note Template for Downstream PRs (will be copied)