Skip to content

networkservices: add list resources - #18630

Open
BBBmau wants to merge 13 commits into
GoogleCloudPlatform:mainfrom
BBBmau:add-networkservices-list-resources
Open

networkservices: add list resources#18630
BBBmau wants to merge 13 commits into
GoogleCloudPlatform:mainfrom
BBBmau:add-networkservices-list-resources

Conversation

@BBBmau

@BBBmau BBBmau commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Adds list-resource generation for the following networkservices resources:

  • google_networkservices_authz_extension
  • google_networkservices_multicast_consumer_association
  • google_networkservices_multicast_domain
  • google_networkservices_multicast_domain_activation
  • google_networkservices_multicast_domain_group
  • google_networkservices_multicast_group_consumer_activation
  • google_networkservices_multicast_group_producer_activation
  • google_networkservices_multicast_group_range
  • google_networkservices_multicast_group_range_activation
  • google_networkservices_multicast_producer_association
`google_networkservices_authz_extension`

`google_networkservices_multicast_consumer_association`

`google_networkservices_multicast_domain`

`google_networkservices_multicast_domain_activation`

`google_networkservices_multicast_domain_group`

`google_networkservices_multicast_group_consumer_activation`

`google_networkservices_multicast_group_producer_activation`

`google_networkservices_multicast_group_range`

`google_networkservices_multicast_group_range_activation`

`google_networkservices_multicast_producer_association`

Tests: Acceptance tests PASSED (confirmed by Validator agent).

Note: 14 resources were scoped out of this PR due to P-17 scope mismatch
(base_url hardcodes global location; list scope does not match resource creation scope).
They are tracked in .agents/knowledge/deferred-list-resources.md
for follow-up PR: add-networkservices-list-resources-followup.

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 05ecff1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 70 files changed, 7723 insertions(+)
google-beta provider View Diff 72 files changed, 8006 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
126 100 2 24
Affected Service Packages
  • networkservices

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 24 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesAgentGatewayListQuery_generated
  • TestAccNetworkServicesAuthzExtensionListQuery_generated
  • TestAccNetworkServicesEdgeCacheKeysetListQuery_generated
  • TestAccNetworkServicesEdgeCacheOriginListQuery_generated
  • TestAccNetworkServicesEdgeCacheServiceListQuery_generated
  • TestAccNetworkServicesEndpointPolicyListQuery_generated
  • TestAccNetworkServicesGatewayListQuery_generated
  • TestAccNetworkServicesGrpcRouteListQuery_generated
  • TestAccNetworkServicesHttpRouteListQuery_generated
  • TestAccNetworkServicesLbRouteExtensionListQuery_generated
  • TestAccNetworkServicesLbTrafficExtensionListQuery_generated
  • TestAccNetworkServicesMeshListQuery_generated
  • TestAccNetworkServicesMulticastConsumerAssociationListQuery_generated
  • TestAccNetworkServicesMulticastDomainActivationListQuery_generated
  • TestAccNetworkServicesMulticastDomainGroupListQuery_generated
  • TestAccNetworkServicesMulticastDomainListQuery_generated
  • TestAccNetworkServicesMulticastGroupConsumerActivationListQuery_generated
  • TestAccNetworkServicesMulticastGroupProducerActivationListQuery_generated
  • TestAccNetworkServicesMulticastGroupRangeActivationListQuery_generated
  • TestAccNetworkServicesMulticastGroupRangeListQuery_generated
  • TestAccNetworkServicesMulticastProducerAssociationListQuery_generated
  • TestAccNetworkServicesServiceLbPoliciesListQuery_generated
  • TestAccNetworkServicesTcpRouteListQuery_generated
  • TestAccNetworkServicesTlsRouteListQuery_generated

View the replaying VCR build log

Step 2: Recording Mode

Caution

Panic occurred during VCR tests

🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@BBBmau VCR tests complete for 05ecff1!

BBBmau added 3 commits August 13, 2026 06:26
@BBBmau Bob Shell
oracledatabase: add list resources
5995fe1
@BBBmau Bob Shell
oracledatabase: remove generate_list_resource from CloudExadataInfras…
ca3e0ab 
…tructureExascaleConfig (P-18 - no list endpoint)
@BBBmau Bob Shell
networkservices: remove generate_list_resource from resources with sc…
6cd4112 
…ope mismatch (P-17)

Removed generate_list_resource from 12 resources that have hardcoded
/locations/global/ in base_url or location parameter with default global.
These resources cannot support list resources without adding a location
parameter, which would be a breaking change per ABSOLUTE PROHIBITIONS.

Failing tests all showed 'no query results found after filtering' due to
P-17 scope mismatch - the list query searches a different scope than where
the resource was created.

Resources removed:
- HttpRoute, EndpointPolicy, TcpRoute, EdgeCacheKeyset, EdgeCacheOrigin,
  EdgeCacheService (hardcoded /locations/global/ in base_url)
- Gateway, Mesh, GrpcRoute, TlsRoute, ServiceLbPolicies, AgentGateway
  (location parameter with default global or scope mismatch)
@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6cd4112:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 66 files changed, 7484 insertions(+)
google-beta provider View Diff 66 files changed, 7484 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • oracledatabase

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for 6cd4112!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1fdc68a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 60 files changed, 6778 insertions(+)
google-beta provider View Diff 60 files changed, 6778 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • oracledatabase

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for 1fdc68a!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 47bb21b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 114 files changed, 6852 insertions(+)
google-beta provider View Diff 117 files changed, 6855 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • bigquery
  • cloudrun
  • cloudscheduler
  • compute
  • discoveryengine
  • networkservices
  • pubsub
  • secretmanager
  • sql
  • storage

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for 47bb21b!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bcf09b5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 60 files changed, 6778 insertions(+)
google-beta provider View Diff 60 files changed, 6778 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • oracledatabase

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for bcf09b5!

BBBmau added 2 commits August 13, 2026 16:46
@BBBmau Bob Shell
Fix missing fmt import in query_test_file template
1c3d9f3 
The query_test_file.go.tmpl template was missing the fmt import,
causing compile errors in generated list query tests across multiple
packages including oracledatabase.

Added fmt to the import block to fix the undefined: fmt errors.
@BBBmau Bob Shell
networkservices: fix GHA check failures - remove unused fmt import
07baf06
@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1c3d9f3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 114 files changed, 6852 insertions(+)
google-beta provider View Diff 117 files changed, 6855 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • bigquery
  • cloudrun
  • cloudscheduler
  • compute
  • discoveryengine
  • networkservices
  • pubsub
  • secretmanager
  • sql
  • storage

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for 1c3d9f3!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 07baf06:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 60 files changed, 6778 insertions(+)
google-beta provider View Diff 60 files changed, 6778 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • oracledatabase

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for 07baf06!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit da9dd0a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 114 files changed, 6852 insertions(+)
google-beta provider View Diff 117 files changed, 6855 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • bigquery
  • cloudrun
  • cloudscheduler
  • compute
  • discoveryengine
  • networkservices
  • pubsub
  • secretmanager
  • sql
  • storage

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for da9dd0a!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6010bf2:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 60 files changed, 6778 insertions(+)
google-beta provider View Diff 60 files changed, 6778 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • oracledatabase

Please fix the compilation errors to complete your PR.

View the build log

@BBBmau VCR tests complete for 6010bf2!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0744b93:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 30 files changed, 3395 insertions(+)
google-beta provider View Diff 30 files changed, 3395 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
112 110 2 0
Affected Service Packages
  • networkservices

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@BBBmau VCR tests complete for 0744b93!

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Aug 13, 2026
Bob Shell
knowledge: add networkservices deferred resources (14 P-17 scope-mism…
98d318e 
…atch) from PR GoogleCloudPlatform#18630
@BBBmau
BBBmau force-pushed the add-networkservices-list-resources branch from c2146ae to 2d92336 Compare August 13, 2026 23:03
@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c2146ae:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 30 files changed, 3395 insertions(+)
google-beta provider View Diff 30 files changed, 3395 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
112 110 2 0
Affected Service Packages
  • networkservices

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@BBBmau VCR tests complete for c2146ae!

@modular-magician

modular-magician commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6b73bc3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 124 files changed, 7910 insertions(+), 43 deletions(-)
google-beta provider View Diff 129 files changed, 8200 insertions(+), 45 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
2378 2193 166 19
Affected Service Packages
  • storage
  • bigquery
  • cloudrun
  • compute
  • networkservices
  • cloudscheduler
  • discoveryengine
  • pubsub
  • secretmanager
  • sql

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRegionNetworkFirewallPolicyListQuery_generated
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccNetworkServicesAgentGatewayListQuery_generated
  • TestAccNetworkServicesEdgeCacheKeysetListQuery_generated
  • TestAccNetworkServicesEdgeCacheOriginListQuery_generated
  • TestAccNetworkServicesEdgeCacheServiceListQuery_generated
  • TestAccNetworkServicesEndpointPolicyListQuery_generated
  • TestAccNetworkServicesGatewayListQuery_generated
  • TestAccNetworkServicesGrpcRouteListQuery_generated
  • TestAccNetworkServicesHttpRouteListQuery_generated
  • TestAccNetworkServicesLbRouteExtensionListQuery_generated
  • TestAccNetworkServicesLbTrafficExtensionListQuery_generated
  • TestAccNetworkServicesMeshListQuery_generated
  • TestAccNetworkServicesServiceLbPoliciesListQuery_generated
  • TestAccNetworkServicesTcpRouteListQuery_generated
  • TestAccNetworkServicesTlsRouteListQuery_generated
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log

Step 2: Recording Mode

Caution

Panic occurred during VCR tests

🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@BBBmau, @malhotrasagar2212 VCR tests complete for 6b73bc3!

@BBBmau
BBBmau force-pushed the add-networkservices-list-resources branch from 6b73bc3 to c2146ae Compare August 14, 2026 20:19
@modular-magician

modular-magician commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c2146ae:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 30 files changed, 3395 insertions(+)
google-beta provider View Diff 30 files changed, 3395 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
112 110 2 0
Affected Service Packages
  • networkservices

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@BBBmau, @malhotrasagar2212 VCR tests complete for c2146ae!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malhotrasagar2212 malhotrasagar2212 Awaiting requested review from malhotrasagar2212

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BBBmau @modular-magician