Skip to content

feat: (storage) add crc32c verification for object content - #18634

Closed
gurusai-voleti wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:issue_532850232
Closed

feat: (storage) add crc32c verification for object content#18634
gurusai-voleti wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:issue_532850232

Conversation

@gurusai-voleti

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: added crc32c verification for data `google_storage_bucket_object_content`

@modular-magician

modular-magician commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c5dd78e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 118 insertions(+)
google-beta provider View Diff 2 files changed, 118 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • storage

Please fix the compilation errors to complete your PR.

View the build log

@gurusai-voleti, @kautikdk VCR tests complete for c5dd78e!

@modular-magician

modular-magician commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b82a2c9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 118 insertions(+)
google-beta provider View Diff 2 files changed, 118 insertions(+)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccDataSourceStorageBucketObjectContent_Crc32cMismatch

Analytics

Total Tests Passed Skipped Affected
137 121 12 4
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccDataSourceStorageBucketObjectContent_Basic
  • TestAccDataSourceStorageBucketObjectContent_Issue15717
  • TestAccDataSourceStorageBucketObjectContent_Issue15717BackwardCompatibility
  • TestAccStorageObject_knownAfterApply

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataSourceStorageBucketObjectContent_Basic
✅ Log TestAccDataSourceStorageBucketObjectContent_Issue15717
✅ Log TestAccStorageObject_knownAfterApply
✅ Log ❌ Error · Log TestAccDataSourceStorageBucketObjectContent_Issue15717BackwardCompatibility

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @melinath, @kautikdk VCR tests complete for b82a2c9!

@gurusai-voleti
gurusai-voleti marked this pull request as ready for review August 13, 2026 11:14
@github-actions
github-actions Bot requested a review from melinath August 13, 2026 11:15
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 474d291:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 135 insertions(+), 5 deletions(-)
google-beta provider View Diff 2 files changed, 135 insertions(+), 5 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@melinath

Copy link
Copy Markdown
Member

We’re currently requesting a change in process for Googlers (or individuals on behalf of Googlers) contributing changes to the Terraform Provider for Google Cloud. Please see go/terraform-ssp-adjustment for details.

@melinath melinath closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants