Add network mode selection.

[jmwachtel]

Add the ability to specify the network mode.

Implements #493

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the container execution capabilities by allowing users to explicitly define the Docker network mode for containers. This provides greater control over container networking, addressing a specific feature request and improving the flexibility of container runtime environments.

Highlights

• Network Mode Configuration: Introduced a new network field within ContainerRunOptions to enable users to specify the Docker network mode for containers.
• Docker Driver Integration: Integrated the new network option into the Docker driver, ensuring that the specified network mode is applied to the HostConfig during container creation.
• Documentation Update: Updated the README.md to document the new network configuration option, including its default value and purpose.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• README.md
  • Added documentation for the new network option under containerRunOptions with a default value of "bridge".
• pkg/drivers/docker_driver.go
  • Modified the hostConfig method to set the NetworkMode property of the Docker HostConfig struct using the new d.runOpts.Network value.
• pkg/types/unversioned/types.go
  • Added a Network field of type string to the ContainerRunOptions struct.
  • Updated the IsSet() method for ContainerRunOptions to include a check for a non-empty Network field.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the ability to specify the network mode for containers via the network option in containerRunOptions. However, it introduces a security risk by allowing the host network mode, which can expose sensitive host-level services to the container. Additionally, a regression was identified in the exec method where test-specific environment variables are overwritten and lost when containerRunOptions are set, potentially leading to incorrect test results and security misconfigurations. A refactoring suggestion is also included for the Docker driver to reduce code duplication and improve maintainability.

[jmwachtel]

@alexeagle or @thesayyn Can one of you take a look at this please?