Repository navigation
Add LensSwitchButton composable - #755
Merged
thestinger merged 7 commits intoOct 6, 2026
Merged
thestinger merged 7 commits into
thestinger merged 7 commits into
Conversation
m4pl
marked this pull request as ready for review
October 5, 2026 21:33
RankoR
approved these changes
Oct 6, 2026
sdsantos
approved these changes
Oct 6, 2026
sdsantos
left a comment
sdsantos
left a comment
There was a problem hiding this comment.
OCD: noticed that the reset icon is slightly of center, making it wiggle a bit when rotating.
reset_icon_off_center.mp4
Comment on lines
+73
to
+76
| .indication( | ||
| interactionSource = interactions, | ||
| indication = ripple(color = colors.contentColor), | ||
| ), |
There was a problem hiding this comment.
Couldn't this indication be added to the Box above, so this additional Box isn't necessary? I tried and it looked the same to me.
Author
There was a problem hiding this comment.
The reset icon is for the preview only. The production version will have a symmetrical icon. Thank you!
Member
|
Maybe I shouldn't have merged this yet. I didn't notice the follow-up comments. |
Member
|
@m4pl Can you fix the regression in another PR? |
Author
|
@thestinger, yes, no problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added a rotation animation for all components.
Closes #738