Repository navigation
Add remaining viewfinder composables - #757
Merged
thestinger merged 11 commits intoOct 7, 2026
Merged
thestinger merged 11 commits into
thestinger merged 11 commits into
Conversation
m4pl
marked this pull request as ready for review
October 6, 2026 21:15
RankoR
approved these changes
Oct 7, 2026
sdsantos
approved these changes
Oct 7, 2026
| package app.grapheneos.camera.ui.components.shuttercore.model | ||
|
|
||
| internal enum class CaptureButtonCore( | ||
| internal enum class ShutterCore( |
There was a problem hiding this comment.
I was surprised when the shutter core did not rotate. But in theory, you wouldn't notice a circle rotating, only the square, but it would end up looking the same, just a small animation. So it's likely not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video_video.mp4
Also grouped some of the code together.
Closes #756