apply hidden API policy after exec spawning + pass disabled compat changes through exec spawning #359
Open
inthewaves wants to merge 2 commits into
Open
apply hidden API policy after exec spawning + pass disabled compat changes through exec spawning #359inthewaves wants to merge 2 commits into
inthewaves wants to merge 2 commits into
Conversation
Exec-spawned app processes do not run the normal zygote post-fork hook that applies hidden API and
test API policy from runtime flags. This change calls ZygoteHooks.postExecSpawn(int) from ExecInit
after normalizing exec-spawned runtime mappings and before resolving the app entrypoint, so policy
is applied before app code is loaded.
Requires the corresponding changes to art and libcore
Test: atest GosSecureSpawnTests:SecureSpawnEnabledHostTest#{acyclicReflectiveDumpCheck,hiddenApiEnforcementCheck}
Dropping the disabled compat change list before RuntimeInit.applicationInit.
made ART treat ALLOW_TEST_API_ACCESS as enabled even when framework compat
had disabled it for the package.
Carry parsed disabled compat changes through ExecInit so exec spawned apps get
the same compat state as the zygote fork path.
Test: atest GosCompatSecureSpawnTests:SecureSpawnEnabledHostTest#testApiCompatDefaultCheck
Test: atest CtsHiddenApiBlocklistCurrentApiTestCases CtsHiddenApiBlocklistTestApiTestCases
(both with exec spawning on, then re-running both tests after turning off exec
spawning + reboot)
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changeset:
Closes GrapheneOS/os-issue-tracker#7899
Exec-spawned app processes do not run the normal zygote post-fork hook that applies hidden API and test API policy from runtime flags. This change calls ZygoteHooks.postExecSpawn(int) from ExecInit after normalizing exec-spawned runtime mappings and before resolving the app entrypoint, so policy is applied before app code is loaded. This fixes the stack overflow crash from GrapheneOS/os-issue-tracker#7899, since the lack of hidden API enforcement introduced a cycle in the recursive reflection dump code in the app:
Also, dropping the disabled compat change list before RuntimeInit.applicationInit. made ART treat ALLOW_TEST_API_ACCESS as enabled even when framework compat had disabled it for the package.
Carry parsed disabled compat changes through ExecInit so exec spawned apps get the same compat state as the zygote fork path.
atest GosCompatSecureSpawnTestsatest CtsHiddenApiBlocklistCurrentApiTestCases CtsHiddenApiBlocklistTestApiTestCases(both with exec spawning on, then re-running both tests after turning off exec spawning + reboot). Without this changeset, these tests were failing with exec spawning on but passing with it off