Make the Pen tool close a path by double-clicking

[krVatsal]

Closes the active pen path when the user intentionally double-clicks.

Closes #3219

[timon-schelling]

!build

[github-actions]

📦 Build Complete for 3fbcaf9
https://db70eac1.graphite.pages.dev

[krVatsal]

Do i need to do something in order to get this pr reviewed?

[timon-schelling]

No, everything fine we're just a bit behind on PRs, situation will improve when Keavon is back from vacation. Thanks for contributing :)

[krVatsal]

Sure, thanks!

[timon-schelling]

!build

[timon-schelling]

Fails to compile now.

[krVatsal]

Fails to compile now.

The conflicts are resolved , can you review this one also.

[timon-schelling]

!build

[timon-schelling]

!build

[github-actions]

📦 Build Complete for e4a80c5
https://31dfa54b.graphite.pages.dev

[timon-schelling]

2026-01-13.18-10-26.mp4

Doesn't seem to work as expected.

[krVatsal]

Can you clarify what is the desired output, drawing should end without closing the path or it should close the the shape on double click?

[timon-schelling]

Closing the path, see the issue you linked.

[krVatsal]

Closing the path, see the issue you linked.

Can you review it now?

[timon-schelling]

!build

[github-actions]

📦 Build Complete for aa9da44
https://ab94894d.graphite.pages.dev

[timon-schelling]

LGTM, @0HyperCube any comments?

[0HyperCube]

Seems good.

I guess you could have bound an event for DoubleClick in the input_mappings.rs but that would confuse the logic since it happens only on mouse up.

[Keavon]

Yeah, from a behavioral perspective, this needs to not close the path upon releasing the mouse from a fast click-click-drag (double-clicking the mouse down part, but dragging during the second mouse down). Currently, that scenario results in unexpected behavior after mouse up.

[timon-schelling]

!build

[github-actions]

📦 Build Complete for eec01d7
https://d159b349.graphite.pages.dev

[Keavon]

This doesn't work as expected in the following case:

capture_16_.mp4

If there is clearly a single endpoint on the path being drawn, it should use that, not the starting point for the current drawing session. But if it attempts to find the endpoint but there is no single unambiguous one, because a vector mesh is involved in the currently-being-drawn subpath, then it should use the current behavior, for example this is correct:

capture_17_.mp4

[krVatsal]

Got it, will improve this.

[Keavon]

I'd like it so if you accidentally double-click, you can hit Ctrl+Z and return to the drawing state you were in immediately before you double-clicked. This already works for regular segment drawing, where you can hit Ctrl+Z to undo each segment and continue where you were immediately before drawing each segment, still interactively placing the next segment. That's how we'd like to work after double-clicking and hitting Ctrl+Z.