Skip to content

Frontend type constraints - #4334

Open
0HyperCube wants to merge 1 commit into
GraphiteEditor:masterfrom
0HyperCube:frontend-type-constraints
Open

Frontend type constraints#4334
0HyperCube wants to merge 1 commit into
GraphiteEditor:masterfrom
0HyperCube:frontend-type-constraints

Conversation

@0HyperCube

@0HyperCube 0HyperCube commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #4330

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 13, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a structured FrontendTypeConstraintForInput enum to handle complex type constraints for node inputs, replacing the previous simple string representation. It includes logic to compute, intersect, and validate these constraints, along with comprehensive unit tests and corresponding frontend updates in NodeCatalog.svelte. The review feedback highlights several instances where the unqualified warn! macro should be replaced with log::warn! to prevent compilation errors, identifies a few typos in comments, and suggests using optional chaining in the frontend to safely access nested properties.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs
Comment thread editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs
Comment thread editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs Outdated
Comment thread editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs Outdated
Comment thread editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs Outdated
Comment thread editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs Outdated
Comment thread frontend/src/components/floating-menus/NodeCatalog.svelte
@0HyperCube
0HyperCube force-pushed the frontend-type-constraints branch from 558bba1 to b5d20e4 Compare July 13, 2026 10:18
timon-schelling
timon-schelling reviewed Jul 15, 2026
View reviewed changes
Comment thread editor/src/messages/portfolio/document/node_graph/utility_types.rs Outdated
timon-schelling
timon-schelling reviewed Jul 15, 2026
View reviewed changes
Comment thread editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs Outdated
@0HyperCube
0HyperCube force-pushed the frontend-type-constraints branch 3 times, most recently from 69372a6 to ec6cdab Compare July 18, 2026 11:08
@0HyperCube
0HyperCube force-pushed the frontend-type-constraints branch from ec6cdab to 121af36 Compare August 12, 2026 21:13
@0HyperCube
0HyperCube force-pushed the frontend-type-constraints branch from 121af36 to d57a2b6 Compare August 12, 2026 21:14
@timon-schelling

timon-schelling commented Aug 12, 2026

Copy link
Copy Markdown
Member

LGTM will merge in the next days

@0HyperCube

0HyperCube commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Thanks.

@timon-schelling

timon-schelling commented Aug 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

!build (Run ID 31647915911)

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
📦 Web Build Complete for d57a2b6
https://c24de265.graphite.pages.dev

Wasm: 37.95 MB — JS: 0.45 MB — CSS: 0.09 MB — Fonts: 0.30 MB — Images: 0.09 MB — All Assets: 38.88 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timon-schelling timon-schelling timon-schelling approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filtering based on types false negatives

2 participants

@0HyperCube @timon-schelling