Skip to content

Terminate container early when logs clearly show termination message#24654

Merged
todvora merged 5 commits intomasterfrom
faster-server-container-termination
Jan 12, 2026
Merged

Terminate container early when logs clearly show termination message#24654
todvora merged 5 commits intomasterfrom
faster-server-container-termination

Conversation

@todvora
Copy link
Copy Markdown
Contributor

@todvora todvora commented Jan 7, 2026

/nocl internal test infra

Description

The graylog server container has custom wait logic with a bunch of regexes for early termination. These contain typical error messages that we consider unrecoverable. I think it would make sense to catch a part of UI#wallString text, which is always a sign of server premature termination.

Motivation and Context

Optimize build/test runs, don't wait for timeouts if we know that we can fail early.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested review from bernd and kroepke January 7, 2026 13:49
@todvora todvora changed the title Terminate container early when logs contain "Terminating. :(" message Terminate container early when logs clearly show termination message Jan 7, 2026
".*\\[Guice/.+?\\].*",
".*java.lang.NoClassDefFoundError.*"
".*java.lang.NoClassDefFoundError.*",
".*Terminating the server :(.*"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ( needs to be escaped.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed, thx!

@todvora todvora requested a review from bernd January 7, 2026 14:20
Copy link
Copy Markdown
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@todvora todvora merged commit 44bef78 into master Jan 12, 2026
24 checks passed
@todvora todvora deleted the faster-server-container-termination branch January 12, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants