Skip to content

feat: ESPI 4.0 Schema Compliance - Phase 25: EndDevice + DTO Cleanup #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfcoffin merged 5 commits into from
Jan 29, 2026
Merged

feat: ESPI 4.0 Schema Compliance - Phase 25: EndDevice + DTO Cleanup #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8c39c1
docs: Add Phase 25 EndDevice implementation plan with integration tes…
dfcoffin Jan 28, 2026
b364dca
refactor: Extract shared DTOs for better maintainability
dfcoffin Jan 28, 2026
c98dd3e
fix: Remove id/uuid from EndDeviceDto for strict ESPI 4.0 compliance
dfcoffin Jan 28, 2026
cf28b34
feat: ESPI 4.0 Schema Compliance - Phase 25: EndDevice + DTO Cleanup …
dfcoffin Jan 29, 2026
7485fab
docs: Add AssertJ chained assertion guidelines
dfcoffin Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ ESPI uses Atom XML feeds for data exchange. Key patterns:
- All tests must pass before committing: `mvn test`
- Run tests for affected module and its dependents: `mvn test -pl <module> -am`
- Integration tests should pass before PR merge: `mvn verify -Pfull-integration`
- **IMPORTANT**: Use AssertJ chained assertions - combine all assertions for a single object into one assertion chain
- Good: `assertThat(retrieved).isPresent().hasValueSatisfying(device -> assertThat(device).extracting(...).containsExactly(...))`
- Bad: Multiple separate `assertThat()` statements for the same object
- This improves readability and provides better failure messages

### Common Development Patterns

Expand Down
Loading
Loading