Open
Conversation
- Add resolve_checkpoint_path() to auto-detect model files in directories - Add get_save_path() to handle directory paths when saving - Support .pkl, .pt, .pth file extensions - Better error messages when checkpoints not found - Fixes IsADirectoryError when checkpoint_filename points to directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
This PR fixes #5 and #6 - the IsADirectoryError when loading pretrained encoders.
Problem
When
checkpoint_filenamein the config points to a directory (e.g.,point_encoder), the code fails with:Solution
Added two helper functions:
resolve_checkpoint_path(path)- Smart path resolver:*.pkl,*.pt,*.pthfilesget_save_path(path, default_filename)- Smart save path handler:Changes
Testing