Skip to content

Dagim H.#20

Open
Unlock7 wants to merge 4 commits intoHackYourAssignment:mainfrom
Unlock7:main
Open

Dagim H.#20
Unlock7 wants to merge 4 commits intoHackYourAssignment:mainfrom
Unlock7:main

Conversation

@Unlock7
Copy link
Copy Markdown

@Unlock7 Unlock7 commented Feb 12, 2026

Note: Re-submitting here as I previously pushed to the incorrect repository.

@reposman33 reposman33 self-assigned this Feb 26, 2026
Copy link
Copy Markdown

@reposman33 reposman33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, no fixes needed

console.log(countVowels("hello")); // returns 2
console.log(countVowels("javascript")); // returns 3
console.log(countVowels("")); // returns 0
console.log(countVowels("Apple")); // returns 1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return 2 but as it is the 'A' is not considered a vowel. If you want to include capital and small caps letters you could convert the vowel to lowercase first:
text[i].toLowerCase() === "a"
... etc

@reposman33 reposman33 added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants