Skip to content

Adding role operations config info#447

Open
heskew wants to merge 2 commits intov5from
role-operations
Open

Adding role operations config info#447
heskew wants to merge 2 commits intov5from
role-operations

Conversation

@heskew
Copy link
Member

@heskew heskew commented Mar 2, 2026

No description provided.

@heskew heskew requested a review from a team as a code owner March 2, 2026 18:52

1. If there are attribute-specific CRUD permissions that need to be enforced on a table, those need to be explicitly described in the `attribute_permissions` array.
1. If a non-hash attribute is given some level of CRUD access, that same access will be assigned to the tables `hash_attribute` (also referred to as the `primary_key`), even if it is not explicitly defined in the permissions JSON.
1. If a non-hash attribute is given some level of CRUD access, that same access will be assigned to the table's `hash_attribute` (also referred to as the `primary_key`), even if it is not explicitly defined in the permissions JSON.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know markdown renderers will treat duplicate numbers as apart of the same numbered list, but for humans like myself, I kinda makes it less readable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoot, yeah. it's not like ai can't help to fix the order whenever a list is updated anyway. that was the real appeal of keeping them all 1. didn't think to change this since it was just some minor update to an existing list.

know if we use both types of ordered lists in docs so it wouldn't be a big deal if I fix this one?

1. If a non-hash attribute is given some level of CRUD access, that same access will be assigned to the table's `hash_attribute` (also referred to as the `primary_key`), even if it is not explicitly defined in the permissions JSON.

_See table_name1s permission set for an example of this – even though the tables hash attribute is not specifically defined in the attribute_permissions array, because the role has CRUD access to attribute1, the role will have the same access to the tables hash attribute._
_See table_name1's permission set for an example of this – even though the table's hash attribute is not specifically defined in the attribute_permissions array, because the role has CRUD access to 'attribute1', the role will have the same access to the table's hash attribute._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe help point people to table_name1?

Suggested change
_See table_name1's permission set for an example of this – even though the table's hash attribute is not specifically defined in the attribute_permissions array, because the role has CRUD access to 'attribute1', the role will have the same access to the table's hash attribute._
_See table_name1's permission set above for an example of this – even though the table's hash attribute is not specifically defined in the attribute_permissions array, because the role has CRUD access to 'attribute1', the role will have the same access to the table's hash attribute._

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can do this and a little more...

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-447

This preview will update automatically when you push new commits.

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heskew heskew force-pushed the role-operations branch from a16ae65 to 311e04b Compare March 3, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants