Remove remember tool registration when Moraine recall stable

[Hmbown]

This pull request removes the remember tool registration logic from the agent's tool setup since Moraine recall is now considered stable.

• Removes should_register_remember_tool function and its tests.
• Removes with_remember_tool block from ToolRegistryBuilder.
• Removes the memory_tool_enabled configuration logic passed to the surface options.
• Deletes the dead crates/tui/src/tools/remember.rs file.
• Cleans up catalog, core engine, and subagent tests that referenced the deprecated tool.

---

PR created automatically by Jules for task 15733292684462658497 started by @Hmbown

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[claude]

Claude finished @Hmbown's task in 2m 56s —— View job

---

Claude's review

• Gather context (diff, CLAUDE.md, AGENTS.md, related code)
• Review correctness of removals (no dangling references)
• Check provider/model safety implications (not applicable to this change)
• Check for reuse/simplification issues
• Check test coverage for removed behavior
• Post final review

Summary: The core removal (registration logic, RememberTool, its tests, and catalog/subagent test references) is clean — I grepped the whole workspace for with_remember_tool, RememberTool, memory_tool_enabled, and the "remember" tool name, and confirmed no dangling references remain in code. However, the PR leaves some plumbing and docs behind that describe the deleted tool.

Findings

1. Dead ToolContext.memory_path plumbing (reuse/simplification)
crates/tui/src/tools/spec.rs:221 (pub memory_path: Option<PathBuf>) was only ever consumed by the now-deleted RememberTool. Nothing under crates/tui/src/tools/ reads it anymore. That leaves two now-pointless writes:

• crates/tui/src/core/engine.rs:3467-3472 — still sets ctx.memory_path, with a comment that literally says "so the model-callable remember tool can append entries", describing code this PR deletes.
• crates/tui/src/main.rs:8287-8289 — same dead assignment.

Since Moraine recall is stable and the tool is gone, memory_path on ToolContext (and these two call sites) can be removed entirely.
Fix this →

2. Stale doc comment on moraine_fallback (correctness of comments)
crates/tui/src/core/engine.rs:373-376 still documents moraine_fallback as gating whether "the remember tool is not registered" — that's no longer true since the tool doesn't exist regardless of this flag. Worth a one-line update while touching this area.

3. User-facing docs not updated

• docs/MEMORY.md still has a full ### 3. The remember tool (auto-update, #489) section (~lines 11, 121-146, 231) describing it as a live, model-callable tool with a JSON schema example.
• docs/TOOL_SURFACE.md:382 still lists remember in the tool table.

Given the PR's premise ("Moraine recall is now considered stable"), these docs should reflect that Moraine is the recall path and the remember tool no longer exists, otherwise users/agents will look for a tool that isn't there.
Fix this →

What's good

• The removal of should_register_remember_tool, with_remember_tool, AgentToolSurfaceOptions::memory_tool_enabled, and the remember.rs module is complete and consistent across tool_setup.rs, registry.rs, main.rs, tool_catalog.rs, and mod.rs.
• Test cleanup in engine/tests.rs and subagent/tests.rs correctly drops references to the removed tool without leaving orphaned assertions.
• The broader memory_enabled / moraine_fallback config fields are correctly left alone — they still gate the legacy push/inject memory path (memory.rs, context_report.rs, tui/ui.rs) which is unrelated to this tool's registration.

Note: I couldn't run cargo check/cargo test in this sandbox (build commands required approval that wasn't available), so the above is based on manual grep/read verification across the workspace rather than a compiler run.

[Hmbown]

Moved to v0.9.4 draft. The remember tool cannot be removed until Moraine availability/default behavior, migration semantics, config/docs, and compatibility are proven together. This is a valid future slice, not a standalone v0.9.1 change.

[google-labs-jules]

Moved to v0.9.4 draft. The remember tool cannot be removed until Moraine availability/default behavior, migration semantics, config/docs, and compatibility are proven together. This is a valid future slice, not a standalone v0.9.1 change.

Understood. Acknowledging that this work is a future slice for v0.9.4 and stopping work on this task.