Skip to content

UID2-XXXX: add fs scan alongside image scan in daily and Java release workflows - #263

Draft
swibi-ttd wants to merge 1 commit into
mainfrom
swi-UID2-XXXX-fs-scan-daily-and-release
Draft

swibi-ttd wants to merge 1 commit into
mainfrom
swi-UID2-XXXX-fs-scan-daily-and-release

Conversation

@swibi-ttd

Copy link
Copy Markdown
Contributor

Ticket: UID2-XXXX

Why

Java services' daily scan and release gate only run an image scan, while build-and-test runs an fs scan. The image scan can't see dependencies that lack META-INF/maven/**/pom.properties once they're unpacked into the fat jar (BouncyCastle, micrometer, reactor-netty, okhttp, kotlin-stdlib, AmazonCorrettoCryptoProvider…), so CVEs in them only surface on PRs. That's why vuln-fix PRs keep failing on CVEs the daily scan never reported (e.g. uid2-admin bcprov CVE-2026-8763 / CVE-2026-13506).

Changes

  • shared-vulnerability-scan-failure-notify.yaml: for Maven image callers (scan_type: image, no dockerfile), run an fs scan before the build, so target/ doesn't exist yet. Slack notify and the failure step fire if either scan fails. Removed the uid2-shared-actions checkout, which nothing used, so the fs scan doesn't scan it.
  • shared-publish-java-to-docker-versioned.yaml: new fsScan job that buildImage needs. A finding fails the release before any version commit, and the scan's files stay out of the workspace commit_pr_and_merge inspects. It doesn't upload SARIF; build-and-test already publishes fs results from main.

No new inputs. The fs scan is always on for these callers.

Expected impact once v3 moves

New HIGH/CRITICAL findings as of today: uid2-admin (bcprov 1.84) and uid2-operator (urllib3 in scripts/aws/requirements.txt). Both repos' build-and-test runs on main are already red on these. The other repos (core, optout, validator, snowflake) have nothing new.

Before releasing v3

Draft until the vuln-scan harness dedupes fs and image findings of the same CVE in the same repo. Otherwise each duplicate gets triaged twice.

🤖 Generated with Claude Code

… workflows

The image scan cannot see dependencies without Maven metadata inside the fat
jar (e.g. BouncyCastle, micrometer, reactor-netty), so CVEs only the PR fs scan
catches never reach the daily alarm or the release gate.

- Daily scan: run an fs scan before the build for Maven image callers; alert
  and fail if either scan fails. Drop the unused uid2-shared-actions checkout so
  the fs scan does not pick it up.
- Java release: run the fs scan as a separate job that buildImage needs, so it
  fails before any version commit and keeps its output out of that workspace.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant