feat(no-priors): create standalone no-priors characterization operator by danielelotito · Pull Request #686 · IBM/ado

danielelotito · 2026-03-11T09:51:58Z

refactor(operators): extract no-priors characterization from TRIM into separate plugin

Create new no-priors-characterization operator plugin per issue feat: create a no-priors characterization operator #683
Move sampling logic to new plugin
Update TRIM to depend on ado-no-priors-characterization
Add examples and documentation
Fix small issue about edge case in high dim sampling

This contributes to #677

Close #683

…o separate plugin - Create new no-priors-characterization operator plugin per issue [#683](#683) - Move sampling logic to new plugin - Update TRIM to depend on ado-no-priors-characterization - Add examples and documentation - Fix small issue about edge case in high dim sampling Related to [#683](#683)

Co-authored-by: Alessandro Pomponio <10339005+AlessandroPomponio@users.noreply.github.com> Signed-off-by: Daniele Lotito <99284466+danielelotito@users.noreply.github.com>

Details: Removed reorder_df_by_importance function (moved to orchestrator/utilities/pandas.py) Optimized set operations for better performance Fixed docstrings to Google format without internal variable references Used unique() instead of set() for NaN-safe handling Removed unnecessary comment Inverted logic in order_df_for_get_index_list_nn_high_dimensional to reduce nesting

…tion The samples parameter now correctly specifies NEW entities to sample, not total desired samples. Previously it subtracted existing measurements, causing crashes when existing measurements exceeded the requested count. Now always samples exactly the requested number of NEW entities, regardless of existing measurements in the space.

…ilities

Co-authored-by: Alessandro Pomponio <10339005+AlessandroPomponio@users.noreply.github.com> Signed-off-by: Daniele Lotito <99284466+danielelotito@users.noreply.github.com>

…ll/686/changes/BASE..6c85e73df3a0511640ac254be9a953977abceeee#r2918667637

"the error level is the same one that's used for exceptions: either this is an exception worthy occurrence or this should be only a warning"

- Add ado-core dependency - Add build-system configuration with setuptools - Add tool.setuptools_scm with root path - Addresses review comment to follow plugin-development.mdc guidelines

…-characterization

- Add optional generatorid parameter to SpacePoint.to_entity() method - Defaults to 'unk' if not specified for backward compatibility - Pass generatorid to Entity constructor to properly track entity origin - Add docstring explaining the parameter and return value This enables callers to specify the generator that created an entity, fixing the issue where entities were always created with 'unk' as the generatorid.

Update get_list_of_entities_from_df_and_space() to pass 'no_priors_characterization' as generatorid when creating entities. This ensures entities are properly tagged with their generator instead of defaulting to 'unk'.

Replace 'unk' with 'no_priors_characterization' in example output to reflect the actual generatorid now being set correctly.

danielelotito · 2026-03-20T13:21:55Z

Merge #724 into main, and then this one (the feat commit of #724 is already cherrypicked and tested here), I will request the review as soon as #724 is approved.

danielelotito · 2026-03-20T16:27:07Z

#724 got approved,
@AlessandroPomponio I tried solve the conflicts with the lock file, but I end up regenerating it, tell me how to proceed if this is not okay

Signed-off-by: DRL NextGen <220003231+DRL-NextGen@users.noreply.github.com>

DRL-NextGen · 2026-03-23T15:33:28Z

Checks Summary

Last run: 2026-03-23T17:03:04.388Z

Mend Unified Agent vulnerability scan found 1 vulnerabilities:

Severity	Identifier	Package	Details	Fix
🔸 Low	CVE-2026-4539	pygments-2.19.2-py3-none-any.whl	A security flaw has been discovered in pygments up to 2.19.2. The impacted element is the function A... A security flaw has been discovered in pygments up to 2.19.2. The impacted element is the function AdlLexer of the file pygments/lexers/archetype.py. The manipulation results in inefficient regular expression complexity. The attack is only possible with local access. The exploit has been released to the public and may be used for attacks. The project was informed of the problem early through an issue report but has not responded yet.	Not Available

AlessandroPomponio

LGTM thanks

danielelotito requested a review from AlessandroPomponio March 11, 2026 09:54

AlessandroPomponio requested changes Mar 11, 2026

View reviewed changes

danielelotito and others added 10 commits March 12, 2026 09:27

docs: Update examples/no-priors-characterization/README.md

c4b05bc

Co-authored-by: Alessandro Pomponio <10339005+AlessandroPomponio@users.noreply.github.com> Signed-off-by: Daniele Lotito <99284466+danielelotito@users.noreply.github.com>

build(description): remove reference to sampling

bf6bff1

feat: Add sort_rows_by_column_names

52569ef

docs: apply suggestions

a5c2df8

docs: apply suggestions

b49aba1

style: format operator.py

e8e2e65

style: format utils/__init__.py

5768fc8

style: format high_dimensional_sampling.py

90ae126

danielelotito requested a review from AlessandroPomponio March 12, 2026 14:08

refactor: update import to use sort_rows_by_column_names from core ut…

d1e85c7

…ilities

AlessandroPomponio requested changes Mar 16, 2026

View reviewed changes

AlessandroPomponio changed the title ~~feat(operator): create standalone no-priors characterization operation~~ feat(no-priors): create standalone no-priors characterization operation Mar 16, 2026

AlessandroPomponio changed the title ~~feat(no-priors): create standalone no-priors characterization operation~~ feat(no-priors): create standalone no-priors characterization operator Mar 16, 2026

danielelotito and others added 10 commits March 16, 2026 15:27

style: address #686 (comment)

dc31a56

docs: address #686 (comment)

3473a37

docs(prettier): Update examples/no-priors-characterization/README.md

678163e

Co-authored-by: Alessandro Pomponio <10339005+AlessandroPomponio@users.noreply.github.com> Signed-off-by: Daniele Lotito <99284466+danielelotito@users.noreply.github.com>

docs: address #686 (comment) , all algos are fast

779e094

refactor: update structure according to https://github.com/IBM/ado/pu…

f7dc9b5

…ll/686/changes/BASE..6c85e73df3a0511640ac254be9a953977abceeee#r2918667637

style(logs): address comment

6f49630

"the error level is the same one that's used for exceptions: either this is an exception worthy occurrence or this should be only a warning"

docs: address #686 (comment)

8d6246a

docs(website): make docs appear

be82e8a

docs: remove text about legacy behavior

de75cca

build: add missing pyproject.toml sections for custom experiments

4930fbc

- Add ado-core dependency - Add build-system configuration with setuptools - Add tool.setuptools_scm with root path - Addresses review comment to follow plugin-development.mdc guidelines

danielelotito requested a review from AlessandroPomponio March 16, 2026 18:13

AlessandroPomponio added the ci Enables CI integration label Mar 18, 2026

AlessandroPomponio requested changes Mar 18, 2026

View reviewed changes

Comment thread examples/no-priors-characterization/README.md Outdated

Comment thread plugins/operators/no-priors-characterization/README.md

Comment thread website/docs/operators/no-priors-characterization.md

danielelotito added 6 commits March 18, 2026 17:53

docs: address #686 (comment)

89ca8f1

docs: replace markdown preprocessor with symbolic links for no-priors…

fef58fb

…-characterization

docs: add symlinks for no-priors-characterization YAML files

f2d2b2d

fix: use generatorid parameter in space_df_connector

47fb44b

Update get_list_of_entities_from_df_and_space() to pass 'no_priors_characterization' as generatorid when creating entities. This ensures entities are properly tagged with their generator instead of defaulting to 'unk'.

docs: update README to reflect correct generatorid

d045d9f

Replace 'unk' with 'no_priors_characterization' in example output to reflect the actual generatorid now being set correctly.

danielelotito mentioned this pull request Mar 20, 2026

feat: add generatorid parameter to SpacePoint.to_entity() #724

Merged

danielelotito marked this pull request as ready for review March 20, 2026 16:27

danielelotito enabled auto-merge March 20, 2026 16:27

danielelotito force-pushed the dl_separate_no_priors branch from f6f5615 to d045d9f Compare March 20, 2026 16:40

danielelotito requested a review from AlessandroPomponio March 20, 2026 16:52

danielelotito and others added 4 commits March 23, 2026 15:11

Merge branch 'main' into HEAD

ececca3

Merge branch 'main' into HEAD

952cf8f

build(deps): update dependencies (#710)

365eb0a

Signed-off-by: DRL NextGen <220003231+DRL-NextGen@users.noreply.github.com>

build(deps): update dependencies (#728)

789953f

Signed-off-by: DRL NextGen <220003231+DRL-NextGen@users.noreply.github.com>

danielelotito force-pushed the dl_separate_no_priors branch from 5be1a8f to 789953f Compare March 23, 2026 15:17

docs: fix table layout

23874bf

AlessandroPomponio previously approved these changes Mar 23, 2026

View reviewed changes

fix: update imports

0f973c6

danielelotito dismissed AlessandroPomponio’s stale review via 0f973c6 March 23, 2026 16:46

AlessandroPomponio approved these changes Mar 23, 2026

View reviewed changes

danielelotito added this pull request to the merge queue Mar 23, 2026

Merged via the queue into main with commit 94c6b8f Mar 23, 2026
18 of 19 checks passed

danielelotito deleted the dl_separate_no_priors branch March 23, 2026 17:26

Conversation

danielelotito commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danielelotito commented Mar 20, 2026

Uh oh!

danielelotito commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DRL-NextGen commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlessandroPomponio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danielelotito commented Mar 11, 2026 •

edited

Loading

danielelotito commented Mar 20, 2026 •

edited

Loading

DRL-NextGen commented Mar 23, 2026 •

edited

Loading