feat(remote): Support local .whl files in fromPyPI and validate source wheels#702
Merged
AlessandroPomponio merged 3 commits intomainfrom Mar 18, 2026
Merged
feat(remote): Support local .whl files in fromPyPI and validate source wheels#702AlessandroPomponio merged 3 commits intomainfrom
AlessandroPomponio merged 3 commits intomainfrom
Conversation
…y-built source wheels - Add `identify_and_copy_local_wheels` to detect local wheel paths in the `fromPyPI` list, copy them to the Ray working directory, and rewrite entries to use `RAY_RUNTIME_ENV_CREATE_WORKING_DIR` so wheels are available on all Ray nodes (not just the head node). - Add `_newest_source_mtime` helper and freshness checks in `_build_source_wheels` to raise an error when a cached/reused wheel is detected instead of a freshly-built one, preventing stale wheels from being shipped between remote executions. - Surface wheel-build progress to the console via `console_print` and pause the spinner during the build step for cleaner output. - Thread `cwd`, `working_dir`, and `seen_basenames` through to `_write_runtime_env` to support the local-wheel copy logic.
Member
|
Checks Summary Last run: 2026-03-18T11:47:32.372Z Code Risk Analyzer vulnerability scan found 1 vulnerabilities:
Mend Unified Agent vulnerability scan found 1 vulnerabilities:
|
Update the four existing test_write_runtime_env_* tests to pass the three new required arguments (cwd, working_dir, seen_basenames) introduced when _write_runtime_env was extended to handle local wheel paths in fromPyPI. Add test_write_runtime_env_local_wheel_in_pypi to verify that a local .whl path in fromPyPI is copied to the working directory and its entry rewritten to use RAY_RUNTIME_ENV_CREATE_WORKING_DIR, while a plain PyPI package name is left unchanged.
AlessandroPomponio
requested changes
Mar 18, 2026
AlessandroPomponio
changed the title
danielelotito
pushed a commit
that referenced
this pull request
Mar 23, 2026
…e wheels (#702) * feat(utils): Support local .whl files in fromPyPI and validate freshly-built source wheels - Add `identify_and_copy_local_wheels` to detect local wheel paths in the `fromPyPI` list, copy them to the Ray working directory, and rewrite entries to use `RAY_RUNTIME_ENV_CREATE_WORKING_DIR` so wheels are available on all Ray nodes (not just the head node). - Add `_newest_source_mtime` helper and freshness checks in `_build_source_wheels` to raise an error when a cached/reused wheel is detected instead of a freshly-built one, preventing stale wheels from being shipped between remote executions. - Surface wheel-build progress to the console via `console_print` and pause the spinner during the build step for cleaner output. - Thread `cwd`, `working_dir`, and `seen_basenames` through to `_write_runtime_env` to support the local-wheel copy logic. * test(cli): Fix _write_runtime_env tests; add local wheel coverage Update the four existing test_write_runtime_env_* tests to pass the three new required arguments (cwd, working_dir, seen_basenames) introduced when _write_runtime_env was extended to handle local wheel paths in fromPyPI. Add test_write_runtime_env_local_wheel_in_pypi to verify that a local .whl path in fromPyPI is copied to the working directory and its entry rewritten to use RAY_RUNTIME_ENV_CREATE_WORKING_DIR, while a plain PyPI package name is left unchanged. * refactor(cli): address code review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
identify_and_copy_local_wheelsto detect local wheel paths in thefromPyPIlist, copy them to the Ray working directory, and rewrite entries to useRAY_RUNTIME_ENV_CREATE_WORKING_DIRso wheels are available on all Ray nodes (not just the head node)._newest_source_mtimehelper and freshness checks in_build_source_wheelsto raise an error when a cached/reused wheel is detected instead of a freshly-built one, preventing stale wheels from being shipped between remote executions.console_printand pause the spinner during the build step for cleaner output.cwd,working_dir, andseen_basenamesthrough to_write_runtime_envto support the local-wheel copy logic.