Feat: EAP UAT Feedbacks batch II - #2816
Draft
susilnem wants to merge 2 commits into
Draft
Conversation
- AttributeError: 'dict' object has no attribute 'lists' - TypeError: __str__ returned non-string (type NoneType)
…view checklist - Add PotentialRisk model and potential_risks/early_actions M2M fields on SimplifiedEAP, required for submission - Add Admin1 model (district + per-selection description) and districts field on CommonEAPFields, as an Admin2 fallback for countries without admin2 data - Add appeal_code to EAPRegistration, fillable only via admin (read-only via API) - Add final_review_checklist_file to EAPRegistration; require it on the UNDER_REVIEW -> TECHNICALLY_VALIDATED transition, clear it alongside validated_budget_file/technically_validated_at on revert to NS_ADDRESSING_COMMENTS - Make SourceInformation.source_link optional for offline-only sources - Add missing max_length on SecureFileField usages to prevent SuspiciousFileOperation on long filenames - Extend file extension validation to cover images across FILE_FIELDS - Change FullEAP.lead_time from CharField to IntegerField (migration uses remove+add instead of alter, to avoid a cast failure on existing non-numeric data) - Update admin/viewset querysets with select_related/prefetch_related for the new relations
susilnem
force-pushed
the
feature/eap-uat-feedback
branch
from
August 24, 2026 09:19
f4ac88b to
1fd7a29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SimplifiedEAP, required for submission
field on CommonEAPFields, as an Admin2 fallback for countries without
admin2 data
via API)
UNDER_REVIEW -> TECHNICALLY_VALIDATED transition, clear it alongside
validated_budget_file/technically_validated_at on revert to
NS_ADDRESSING_COMMENTS
SuspiciousFileOperation on long filenames
uses remove+add instead of alter, to avoid a cast failure on existing
non-numeric data)
for the new relations
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.