Feat/add html rendering logic in tooltips#60
Conversation
|
Thanks for the contribution! Here is some feedback from the review of this PR: 1. Angular Version/Rebase ConflictThe branch is currently based on an older commit (from when the library was on Angular 8). Since 2. Transition Delay for Hovering Over TooltipsIn if (this.config.renderTooltipAsHtml) {
// give the pointer time to travel onto the tooltip to click links inside it
this.tooltipHideTimeout = setTimeout(() => {
this.inputTooltipShown = false;
}, 0) as unknown as number;
}A delay of 3. Missing Tooltip Origin in Default TemplateIn the default template inside (mouseenter)="showTooltip(item[config.hoverProperty])"Because the second argument 4. XSS Security with
|
e5e587e to
58a1946
Compare
|
Incorporated your comments in the Code, Can you have a look, Thanks. |
AhsanAyaz
left a comment
There was a problem hiding this comment.
All feedback addressed. The rebase looks good, transition delay is corrected, and cdkOverlayOrigin was added to the default template. Excellent work!
Feature: Added Rendering of HTML content inside Tooltips and make the tooltips hoverable
Added a config for configuring how the content inside the tooltip being shown, i.e plain text or as HTML.
Why need for this Feature
In ICplan we have a requirement that the Channel Description's(tooltip content) can contain hyperlinks
