Skip to content

AdServer on dashboard#674

Open
codeispoetry wants to merge 2 commits intodevelopfrom
feature/adserver
Open

AdServer on dashboard#674
codeispoetry wants to merge 2 commits intodevelopfrom
feature/adserver

Conversation

@codeispoetry
Copy link
Copy Markdown
Contributor

@codeispoetry codeispoetry commented Dec 19, 2025

Description

to get closer to our Q1 goal of having adzones in wp-admin, the first step is showing a dummy adzone

Checklist

  • Acceptance Criteria are fulfilled (or there is no ticket)
  • tests added if necessary
  • docs added if necessary

Screenshots / Recordings

Bildschirmfoto vom 2025-12-19 10-06-03

manual testing

  • done / trivial change (docs, ...)
  • requested
    Please replace this line with instructions on how to test your changes

Reviewer checklist

  • if requested manual testing done
  • sufficient tests
  • sufficient docs
  • general Code Review

@codeispoetry codeispoetry marked this pull request as ready for review January 13, 2026 08:21
use ionos\essentials\Tenant;
use const ionos\essentials\PLUGIN_FILE;

function render(): void
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like render() also more than render_callback() 👍

@codeispoetry codeispoetry changed the title [skip ci] PoC AdServer on dashboard AdServer on dashboard Feb 12, 2026
OAO.q = OAO.q || {};
OAO.q.c = OAO.q.c || [];

OAO.q.c.push(['setFrontendToken', '<?php echo esc_js($_GET['token'] ?? 'adserver_default_token'); ?>']);
Copy link
Copy Markdown
Contributor

@tobibode tobibode Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't work on stretch because the executable php files are allowlisted.
to make this work we could turn this into a static html file & take the token via js from the window object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants