Skip to content

fix(financial grid): unifying currency formatting #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChronosSF merged 1 commit into from
Jun 18, 2026
Merged

fix(financial grid): unifying currency formatting #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 17 additions & 13 deletions projects/finance-grid/src/finance-grid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { customElement, query, state } from "lit/decorators.js";
import { dataService } from "./services/data.service";
import { TRENDING_DOWN, TRENDING_UP } from "./assets/icons/icons";
import { configureTheme, defineComponents, IgcAvatarComponent, IgcIconComponent, IgcInputComponent, IgcLinearProgressComponent, registerIconFromText } from "igniteui-webcomponents";
import { FilteringLogic, IgcCellTemplateContext, IgcFilteringExpressionsTree, IgcGridComponent, IgcStringFilteringOperand } from "igniteui-webcomponents-grids/grids";
import { FilteringLogic, IgcCellTemplateContext, IgcColumnPipeArgs, IgcFilteringExpressionsTree, IgcGridComponent, IgcStringFilteringOperand } from "igniteui-webcomponents-grids/grids";
import "igniteui-webcomponents-grids/grids/combined.js";
import financeStyles from "./finance-grid.scss?inline";

Expand Down Expand Up @@ -37,6 +37,10 @@ export default class FinanceGrid extends LitElement {
// @state()
// private isLoading = true;

private currencyDigitsFormat: IgcColumnPipeArgs = {
digitsInfo: '1.2-2'
};

private profitConditionHandler = (rowData: any, columnKey: string) => {
return rowData[columnKey] >= 0;
};
Expand Down Expand Up @@ -133,7 +137,7 @@ export default class FinanceGrid extends LitElement {

return html`
<link rel="stylesheet" href="${import.meta.env.BASE_URL}themes/bootstrap.css" />
<igc-grid .data="${this.financeData}" .isLoading="${!this.financeData.length}" primary-key="id" row-selection="multiple" class="grid-sizing">
<igc-grid .data="${this.financeData}" .isLoading="${!this.financeData.length}" primary-key="id" class="grid-sizing">
<igc-grid-toolbar>
<igc-grid-toolbar-title>Financial Portfolio</igc-grid-toolbar-title>
<igc-input type="search" placeholder="Filter by Asset" @igcInput="${this.filter}"></igc-input>
Expand All @@ -143,17 +147,17 @@ export default class FinanceGrid extends LitElement {
<igc-grid-toolbar-exporter></igc-grid-toolbar-exporter>
</igc-grid-toolbar-actions>
</igc-grid-toolbar>
<igc-column field="id" header="Symbol" ?sortable="${true}" width="7%"></igc-column>
<igc-column field="holdingName" header="Asset" ?sortable="${true}" width="15%" .bodyTemplate="${this.assetTemplate}"></igc-column>
<igc-column field="positions" header="Position" ?sortable="${true}" data-type="number" width="6%"></igc-column>
<igc-column field="value.boughtPrice" header="Average Cost/Share" data-type="currency" ?sortable="${true}" width="10%"></igc-column>
<igc-column field="value.currentPrice" header="Last Price" data-type="currency" ?sortable="${true}" width="7%"></igc-column>
<igc-column field="dailyPercentageChange" header="Daily Change %" .cellClasses="${this.profitLossValueClasses}" data-type="percent" .bodyTemplate=${this.dailyChangePercentageTemplate} ?sortable="${true}" width="10%"> </igc-column>
<igc-column field="marketValue" header="Market Value" data-type="currency" ?sortable="${true}" width="5%"></igc-column>
<igc-column field="profitLossValue" header="NET Profit/Loss" .bodyTemplate="${this.profitLossValueTemplate}" ?sortable="${true}" data-type="currency" width="10%" .cellClasses="${this.profitLossValueClasses}"></igc-column>
<igc-column field="profitLossPercentage" header="NET Profit/Loss %" ?sortable="${true}" data-type="percent" width="10%" .cellClasses="${this.profitLossValueClasses}" .bodyTemplate=${this.dailyChangePercentageTemplate}></igc-column>
<igc-column field="allocation" header="Allocation" ?sortable="${true}" data-type="percent" width="10%" .bodyTemplate="${this.allocationTemplate}"></igc-column>
<igc-column field="holdingPeriod" header="Holding Period" ?sortable="${true}" width="8%" .bodyTemplate="${this.holdingPeriodTemplate}"></igc-column>
<igc-column field="id" header="Symbol" ?sortable="${true}" width="7%" minWidth="68px"></igc-column>
<igc-column field="holdingName" header="Asset" ?sortable="${true}" width="15%" minWidth="100px" .bodyTemplate="${this.assetTemplate}"></igc-column>
<igc-column field="positions" header="Position" ?sortable="${true}" data-type="number" width="6%" minWidth="68px"></igc-column>
<igc-column field="value.boughtPrice" header="Average Cost/Share" data-type="currency" ?sortable="${true}" width="10%" minWidth="80px" .pipeArgs="${this.currencyDigitsFormat}"></igc-column>
<igc-column field="value.currentPrice" header="Last Price" data-type="currency" ?sortable="${true}" width="7%" minWidth="80px" .pipeArgs="${this.currencyDigitsFormat}"></igc-column>
<igc-column field="dailyPercentageChange" header="Daily Change %" .cellClasses="${this.profitLossValueClasses}" data-type="percent" .bodyTemplate=${this.dailyChangePercentageTemplate} ?sortable="${true}" width="7%" minWidth="110px"> </igc-column>
<igc-column field="marketValue" header="Market Value" data-type="currency" ?sortable="${true}" width="8%" minWidth="110px" .pipeArgs="${this.currencyDigitsFormat}"></igc-column>
<igc-column field="profitLossValue" header="NET Profit/Loss" .bodyTemplate="${this.profitLossValueTemplate}" ?sortable="${true}" data-type="currency" width="10%" .cellClasses="${this.profitLossValueClasses}" minWidth="90px" .pipeArgs="${this.currencyDigitsFormat}"></igc-column>
<igc-column field="profitLossPercentage" header="NET Profit/Loss %" ?sortable="${true}" data-type="percent" width="10%" .cellClasses="${this.profitLossValueClasses}" .bodyTemplate=${this.dailyChangePercentageTemplate} minWidth="98px"></igc-column>
<igc-column field="allocation" header="Allocation" ?sortable="${true}" data-type="percent" width="10%" .bodyTemplate="${this.allocationTemplate}" minWidth="80px"></igc-column>
<igc-column field="holdingPeriod" header="Holding Period" ?sortable="${true}" .bodyTemplate="${this.holdingPeriodTemplate}" minWidth="50px"></igc-column>
</igc-grid>
`;
}
Expand Down
Loading