1.21.9 support + delay action feature

[tehbeard]

• Bump mod version to 1.2.9
• Updated to 1.21.9
• Updated owo-lib dep to 0.12.22+1.21.9
• Adds a delay action, this adds a configurable delay (given in ticks) before the next action is executed.
• 1.21.8 -> 1.21.9 Involved changes to the keybind code, cursory testing shows it to be working, but has not been extensively tested alongside other mods.

For users who don't want to wait: A build is available on my fork here, in the artifacts.zip. Use at own risk.

[tehbeard]

Not sure why the auto build failed here, ran fine on my branch.

https://github.com/tehbeard/quick-menu/actions/runs/18170950921

[maybeToby90]

Hey @tehbeard
Unfortunately, I don't know how to contact you, apparently not at all. I'm always a little overwhelmed by GitHub because I find the overview very confusing, but apparently there's no messaging function here either 😅

Since I'm currently using your fork version of Quick Menu for 1.21.8 and 1.21.10, I wanted to ask you if it's possible for users to add their own icons. Is there already a way to do this, or is it not feasible at all?

Sending lots of love & thanks for your Forks 🩷
Tobi

[tehbeard]

@maybeToby90 Custom icons can be added (The code's existed since before I started my fork), but it's not as simple as just adding a png unfortunately. I've documented what I can find from checking the mod code, and links to relevant sections of the wiki.

First up you can set a field labelled "custom model data", under the advanced section when editing a action.

This defaults to a 0 as previously this used the model_id in older versions of the mod/minecraft, prior to the data component change in 1.20.5.

This value now gets passed in as a "string" (letters and such are allowed) into the custom_model_data component on the item.
https://minecraft.wiki/w/Data_component_format#custom_model_data

example: If you picked a redstone_block, and set this field to the value "star", the item would render the same as one from the following give command:
/give tehbeard redstone_block[custom_model_data={strings:["star"]}]

You need to make a resource pack, that overrides the item model for the item you use, that uses this custom model data to render your custom icon.

https://minecraft.wiki/w/Items_model_definition#select

Unfortunately, I don't really have much first hand knowledge on how to make such a resource pack.
I know they're doable because that's how Hermitcraft did those custom shop trophies etc in the previous seasons.

https://github.com/Simplexity-Development/Custom_Model_Data_Guide this seems to have a good guide from what I can tell, it gives an example of how to modify the iron_nugget so that by default it renders as normal, but if custom_model_data is set it then renders a different texture. This does also carry a slight chance of clashes with a regular resource pack you use if it changes the models for it's own uses (typically this is on stuff like swords to show durability based textures etc)

When I get to updating my fork for 1.21.11, I will have a look into supporting the item_model option as well.

This won't cut down on the resource pack work you'd need to do, but it would prevent clashes, as you wouldn't need to modify an existing item, you just add a new custom model (e.g. a toby:backpack model) and use that, rather than having to modify an exsiting model for raw_cod or such to add the backpack model to it.

I'll also look at spending some time looking at that C.M.D guide I linked, and make an example resource pack to showcase how to add custom icons.

[maybeToby90]

Oh wow, thank you so much for this very detailed answer and information 🩷

It's sad that it was solved in such a complicated way. Just reading it raised even more questions, so I'll have to read up on the links later.

Thanks again for your efforts and for updating the mod.

[justeraseme]

At this rate, you should just fork the original mod and continue it

[maybeToby90]

Yeah, I really think that would be best. There doesn't seem to be any more of the original mod. A fork version from you, also on Modrinth, would be really nice. If you want to do that to yourself

[tehbeard]

Yeah. I'll start looking at how to publish on Modrinth and get the 1.21.9/10 one uploaded.

1.21.11 - I'm going to try and remove owo-lib as a dependency, and just move to calls to Minecraft/fabric's GUI code.

[ImCodist]

Please do not publish a separate fork of this mod on Modrinth.
Feel free to make your own version of the mod, but I'd rather not have my code published through two separate instances with unauthorized monetization of my code and assets.
Thank you.

[maybeToby90]

Please do not publish a separate fork of this mod on Modrinth. Feel free to make your own version of the mod, but I'd rather not have my code published through two separate instances with unauthorized monetization of my code and assets. Thank you.

Maybe I expressed myself wrong, I didn't mean that I or someone else should publish the code, it's your fork version after all.

My concern was that you offer it yourself on Modrinth as a fork version. If that's what you want, but if not, then that's perfectly fine, it was just an idea on my part, sorry if it came across as overly pretentious.

For my part, I would never just take someone else's code and upload it somewhere. That should be an unwritten law here.

Happy New Year to you, by the way, and lots of success, happiness and health!

[tehbeard]

Please do not publish a separate fork of this mod on Modrinth. Feel free to make your own version of the mod, but I'd rather not have my code published through two separate instances with unauthorized monetization of my code and assets. Thank you.

Will you be approving the PRs, and uploading the versions of the mod for newer Minecraft versions then?

The last upload to modrinth was 11 months ago, for 1.21.4

The only reason discussion of publishing a fork even arose is because people want to use this mod, and use it on modern versions.

I have friends who use this mod as an accessibility aid due to the features it offers for reducing the strain of writing out common commands on a server.

I did not seek to fork in order to gain any monetary value, and I find the insinuation of that, insulting.

The only reason I considered it is that it makes distribution to those who still want to use quick menu easier, and avoid issues with the dependency on owolib which isn't automatically resolved if they download the jar from github; and ensure it is discoverable by those but don't dig deep into a github issue and PR list on a project that appears dead.

[ImCodist]

I have been extremely busy with work and other more fulfilling projects to continue any work on this mod at this time.
I am grateful for the people who enjoy this mod, and especially grateful for your continued updates, but my main issue is that your fork has deviated from mine in a way I'm not satisfied with.
And again, I simply do not have the time to manually review and request changes to your PR's.

Furthermore, I did not mean to insult you, but the monetization aspect is a real concern of mine.
There are plenty of people out there who'll take free projects for granted and use them to make a quick buck.
I've been a victim of it before, and I am tired of it.
So, I apologize if that came off wrong.

For the time being, I'd be willing to update the projects Modrinth page to include a link to your fork's GitHub.
But I'd like to reiterate that an additional Modrinth page for the project is off the table.

I apologize for only revealing my thoughts on the matter now, I am not very sociable.

Also, thank you Tony. I hope you had a great new years as well.