Conversation
Ceng23333
force-pushed
the
issue/193
branch
2 times, most recently
from
9aaef0e to
89acdcc
Compare
Ceng23333
requested review from
PanZezhong1725,
crapromer,
ma-hang and
whjthu
ma-hang
reviewed
Feb 3, 2026
| last_len = getattr(req, "_stream_last_yielded_length", 0) | ||
| token_text = decoded_text[last_len:] | ||
| if token_text: | ||
| req._stream_last_yielded_length = len(decoded_text) |
Contributor
There was a problem hiding this comment.
处理尾部可能存在的不完整字符（max_tokens 导致的finished）
| top_k=int(pick("top_k", self.top_k)), | ||
| max_tokens=int(max_tokens) if max_tokens is not None else None, | ||
| stop=stop, | ||
| stop_token_ids=stop_token_ids, |
Contributor
There was a problem hiding this comment.
_check_request_finished中添加stop_token_ids的检查
Contributor
There was a problem hiding this comment.
start_time删掉，下面_chat的start_time也删掉
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
Signed-off-by: Ceng23333 <441651826@qq.com>
ma-hang
approved these changes
Feb 5, 2026
whjthu
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#193