Remove const from return type of ImageConstIterator::GetIndex(), remove static_cast
#5794
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ImageConstIterator::m_Offset` is already declared as `OffsetValueType`, so the static_cast is redundant.
Following C++ Core Guidelines, July 8, 2025, "Don’t return `const T`", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#rf-return-const
dzenanz
approved these changes
Feb 11, 2026
Member
|
Can you also add replacements of Iterator by IteratorWithIndex to this PR? Or do you intend to do that in another PR? Those changes are also |
hjmjohnson
approved these changes
Feb 11, 2026
Contributor
Author
I would prefer to keep this simple style PR just the way it is now. 🤷 It takes more time to figure out which of the iterator declarations may be adjusted for better performance. I would prefer to do so after pull request #5787 (introducing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small style commits, as suggested by @dzenanz at #5787 (comment)