Extend _tensor_elementwise_impl (unary) part 2#2796
Open
vlad-perevezentsev wants to merge 10 commits intomove_tensor_elementwise_impl_unaryfrom
Open
Extend _tensor_elementwise_impl (unary) part 2#2796vlad-perevezentsev wants to merge 10 commits intomove_tensor_elementwise_impl_unaryfrom
_tensor_elementwise_impl (unary) part 2#2796vlad-perevezentsev wants to merge 10 commits intomove_tensor_elementwise_impl_unaryfrom
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2796/index.html |
vlad-perevezentsev
force-pushed
the
move_tensor_elementwise_impl_unary_par_2
branch
from
0cdc3e4 to
7f444bd
Compare
vlad-perevezentsev
changed the title
_tensor_elementwise_impl (unary) part 2_tensor_elementwise_impl (unary) part 2
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
ndgrigorian
approved these changes
Mar 12, 2026
Collaborator
ndgrigorian
left a comment
ndgrigorian
left a comment
There was a problem hiding this comment.
I looked over includes and nothing stood out, this one LGTM
antonwolfy
reviewed
Mar 12, 2026
| //===---------------------------------------------------------------------===// | ||
|
|
||
| #pragma once | ||
| #include <cmath> |
Contributor
There was a problem hiding this comment.
This header is not needed. The file uses sycl::floor() (line 83), not any std:: math functions from
|
|
||
| template <typename argT, | ||
| typename resT = bool, | ||
| std::uint8_t vec_sz = 4u, |
Contributor
There was a problem hiding this comment.
The file uses std::uint8_t at line 78 but doesn't include <cstdint>
| @@ -0,0 +1,115 @@ | |||
| //===----------- Implementation of _tensor_impl module ---------*-C++-*-/===// | |||
| @@ -0,0 +1,118 @@ | |||
| //===----------- Implementation of _tensor_impl module ---------*-C++-*-/===// | |||
| @@ -0,0 +1,117 @@ | |||
| //===----------- Implementation of _tensor_impl module ---------*-C++-*-/===// | |||
| @@ -0,0 +1,117 @@ | |||
| //===----------- Implementation of _tensor_impl module ---------*-C++-*-/===// | |||
| @@ -0,0 +1,115 @@ | |||
| //===----------- Implementation of _tensor_impl module ---------*-C++-*-/===// | |||
| @@ -0,0 +1,117 @@ | |||
| //===----------- Implementation of _tensor_impl module ---------*-C++-*-/===// | |||
| import dpctl_ext.tensor._tensor_elementwise_impl as ti_ext | ||
| import dpnp | ||
| import dpnp.backend.extensions.ufunc._ufunc_impl as ufi | ||
| from dpnp.dpnp_algo.dpnp_elementwise_common import DPNPBinaryFunc, DPNPUnaryFunc |
Contributor
There was a problem hiding this comment.
Suggested change
| from dpnp.dpnp_algo.dpnp_elementwise_common import DPNPBinaryFunc, DPNPUnaryFunc | |
| from .dpnp_algo.dpnp_elementwise_common import DPNPBinaryFunc, DPNPUnaryFunc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
_tensor_elementwise_implwith part of the unary functions: