Use python 3.14 environment in GitHub workflows#2922
Open
antonwolfy wants to merge 7 commits into
Open
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2922/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev2=py314h509198e_29 ran successfully. |
vlad-perevezentsev
approved these changes
May 19, 2026
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
60bde39 to
cded1c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the remaining GitHub workflows and conda environments to run under python 3.14, and bumps coveralls to 4.1.0 (which supports 3.14).
Version bumps (3.13/3.12 → 3.14)
check-onemath.yaml— oneMath interface testsconda-package.yml— array API conformance tests (python-ver)environments/building_docs.yml— docs buildenvironments/upload_cleanup_conda_pkg.yml— conda package upload/cleanupenvironments/coverage.yml— coverage job (was pinned to3.12)Coverage job fixes for python 3.14
Bumping the coverage environment from 3.12 to 3.14 surfaced two failures unrelated to dpnp's runtime code — both stem from how coverage instrumentation interacts with 3.14's
sys.monitoring:1. Build failure —
undeclared identifier '__Pyx_MonitoringEventTypes_CyGen_count'Coverage builds compile every extension with
CYTHON_TRACE=1(DPNP_GENERATE_COVERAGE=ON), but Cython line tracing also needs the matching# cython: linetrace=Truedirective at cythonize time. Three.pyxfiles were missing it (_slicing.pyx,_stride_utils.pyx,_types.pyx): without the directive, Cython references__Pyx_MonitoringEventTypes_CyGen_count(from the shared generator/coroutine struct) but never defines it. On python ≤3.12 the guardingCYTHON_USE_SYS_MONITORINGmacro is0, so the code was unreachable — which is why the previous3.12pin hid this; on 3.13+ it becomes reachable and fails to compile. Added the directive to the three files. As a side effect, these files were previously producing no line-coverage data and are now measured.2. Test failures —
test_dlpack.py::TestDLPack::test_invaid_stream[scalar|dictionary|device]coverage.py 7.9+ makes the
sys.monitoringcore (sysmon) the default on python 3.14. That core (a) does not support plugins such as theCython.Coverageplugin used here, and (b) corrupts the pending exception when a C/Cython function raises — turning dpctl's correctTypeErrorfromusm_ndarray.__dlpack__into aSystemError, soassert_raises(TypeError, ...)fails. Pinned the measurement core back toctraceviacore = "ctrace"in[tool.coverage.run](pyproject.toml).ctracesupports both the Cython plugin and branch coverage, so no coverage data is lost.