Feat: Add free-threaded Python support - #357
Open
vchamarthi wants to merge 2 commits into
Open
Conversation
vchamarthi
requested review from
antonwolfy,
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
August 3, 2026 16:28
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables free-threaded (PEP 703) Python support for mkl_fft by marking the Cython extension as free-threading compatible, aligning build tooling requirements, and expanding CI/conda packaging to cover both CPython 3.14 (GIL) and 3.14t (free-threaded) variants.
Changes:
- Mark
mkl_fft/_pydfti.pyxasfreethreading_compatiblefor Cython and pin Cython to>=3.1.0across build/packaging. - Update conda recipes to require
cython >=3.1.0and removepython-gilpins. - Extend conda/pip CI matrices to build/test CPython 3.14
cp314andcp314tvariants and adjust cache/artifact naming accordingly.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Pins build-time Cython to >=3.1.0 for free-threading support features. |
| mkl_fft/_pydfti.pyx | Declares the extension as free-threading compatible via a Cython directive. |
| conda-recipe/meta.yaml | Aligns Intel-channel recipe with Cython >=3.1.0 and drops python-gil pins. |
| conda-recipe-cf/meta.yaml | Aligns conda-forge recipe with Cython >=3.1.0 and drops python-gil pins. |
| AGENTS.md | Updates documented build dependencies to reflect the Cython pin. |
| .github/workflows/conda-package.yml | Adds 3.14 cp314 and cp314t build/test coverage and distinguishes variants in cache/artifacts. |
| .github/workflows/conda-package-cf.yml | Mirrors conda-forge CI to build/test both 3.14 variants and adjust cache/artifacts. |
| .github/workflows/build-with-standard-clang.yml | Adds 3.14t to the Python matrix (currently incompatible with actions/setup-python). |
| .github/workflows/build-with-clang.yml | Adds 3.14t to the Python matrix (currently incompatible with actions/setup-python). |
| .github/workflows/build_pip.yml | Adds 3.14 cp314/cp314t variants via a python_spec matchspec approach. |
antonwolfy
reviewed
Aug 10, 2026
antonwolfy
reviewed
Aug 31, 2026
| - name: Install mkl_fft dependencies | ||
| run: | | ||
| pip install meson-python ninja cython cmake | ||
| pip install meson-python ninja "cython>=3.1.0" cmake |
Collaborator
There was a problem hiding this comment.
Need to update .github/workflows/coverity.yml also with "cython>=3.1.0"
ndgrigorian
reviewed
Aug 31, 2026
| "meson-python>=0.13.0", | ||
| "ninja", | ||
| "Cython", | ||
| "Cython>=3.1.0", |
Collaborator
There was a problem hiding this comment.
please add the free-threading compatible (beta) classifier below as well
Collaborator
|
Testing this PR captured a few issues, which are being resolved in a separate PR. When above feedback is applied, I think this can go in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable free-threaded Python support for
mkl_fft.The Meson migration in #303 is now merged, so this PR contains only the
changes required for free-threaded support.
Depends on IntelPython/mkl-service#213 for a compatible free-threaded
mkl-servicepackage.