Open
Conversation
ndgrigorian
force-pushed
the
build-with-meson
branch
from
52b62f9 to
65e6561
Compare
* removes setup.py and generate_mklrand_c.py * updates pyproject.toml * adds meson.build
ndgrigorian
force-pushed
the
build-with-meson
branch
from
dcba86f to
f33636f
Compare
we search for MKL with cmake. Also drop pkg-config from meta.yamls and use cmake
ndgrigorian
force-pushed
the
build-with-meson
branch
from
bb95253 to
4a09dab
Compare
remove tbb from build-with-clang workflow
ndgrigorian
force-pushed
the
build-with-meson
branch
from
b26da80 to
383dd0f
Compare
aligns more closely with conda-forge feedstock
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes moving from
setuptoolstomeson-pythonas themkl_randombuild systemmeson-pythonis already used by NumPy and allowssetup.pyto be removed (with its logic moved into themeson.buildscript)