Add combined results and plot generation - #219
Open
avolkov-intel wants to merge 7 commits into
Open
Conversation
Contributor
|
@avolkov-intel Please document these options in the .md files where the other options are described. |
avolkov-intel
force-pushed
the
dev/anatolyv-combined-results
branch
from
August 17, 2026 11:11
ceda047 to
1886459
Compare
Collaborator
Author
Done |
Collaborator
Author
|
CI failures are not related to this PR |
ethanglaser
reviewed
Aug 17, 2026
| if ( | ||
| "n_jobs" in results.columns | ||
| and results["n_jobs"].isna().any() | ||
| and results["n_jobs"].notna().any() |
Contributor
There was a problem hiding this comment.
Would it make more sense to drop and results["n_jobs"].notna().any() and just drop n_jobs col if any are na? Or what is the reason for this change
| Each block ends with per-dtype and total GEOMEAN formula rows plus a speedup color scale. | ||
| Returns list of (group_name, total_geomean_row, {dtype: geomean_row}) for the summary sheet. | ||
| """ | ||
| KNN = ("KNeighborsClassifier", "KNeighborsRegressor") |
Contributor
There was a problem hiding this comment.
Is there a way to make this knn-specific logic more flexible? ie right now we have 2 different knn methods but what it we wanted to use 2 different LogReg solvers - would we need to keep adding in algo-specific logic or can we set it up to be more general?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New CLI options
--combined-results— builds two extra sheets:brute/kd_tree; rows sorted by dtype then dataset; each group ends with per-dtype and total
GEOMEANformula rows with a per-group speedup color scale.section and total geomeans.
--draw-plots/--plot-output <path>— renders a Training/Inference speedup bar chart (geomean per algorithm, combining fp32 & fp64) withIntel-branded titles and disclaimer footnote.
Other changes
--performance-stability-metricsnow additionally emits amedian time[ms]column (alongside existing1st run time[ms],time CV), included in theindividual sheets and "All cases".
Use
--compatibility-modetogether with--combined-resultsso sklearn/sklearnex rows merge correctly.Completeness and readability
Testing