Conversation
18 tasks
jasagredo
force-pushed
the
js/lsm
branch
5 times, most recently
from
641cd76 to
d19a961
Compare
lehins
reviewed
Nov 4, 2025
Comment on lines
1076
to
1077
| forMachine _verb (Conway.ConwayWithdrawalsMissingAccounts _) = mconcat [ "todo" .= String "todo"] | ||
| forMachine _verb (Conway.ConwayIncompleteWithdrawals _) = mconcat [ "todo" .= String "todo"] |
Contributor
There was a problem hiding this comment.
Suggested change
| forMachine _verb (Conway.ConwayWithdrawalsMissingAccounts _) = mconcat [ "todo" .= String "todo"] | |
| forMachine _verb (Conway.ConwayIncompleteWithdrawals _) = mconcat [ "todo" .= String "todo"] | |
| forMachine _ (Conway.ConwayWithdrawalsMissingAccounts missingWithdrawals) = | |
| mconcat [ "kind" .= String "ConwayWithdrawalsMissingAccounts" | |
| , "withdrawals" .= unWithdrawals missingWithdrawals | |
| ] | |
| forMachine _ (Conway.ConwayIncompleteWithdrawals incompleteWithdrawals) = | |
| mconcat [ "kind" .= String "ConwayIncompleteWithdrawals" | |
| , "withdrawals" .= unWithdrawals incompleteWithdrawals | |
| ] |
lehins
reviewed
Nov 4, 2025
Comment on lines
337
to
338
| toObject _verb (Conway.ConwayWithdrawalsMissingAccounts _) = mconcat [ "todo" .= String "todo"] | ||
| toObject _verb (Conway.ConwayIncompleteWithdrawals _) = mconcat [ "todo" .= String "todo"] |
Contributor
There was a problem hiding this comment.
Suggested change
| toObject _verb (Conway.ConwayWithdrawalsMissingAccounts _) = mconcat [ "todo" .= String "todo"] | |
| toObject _verb (Conway.ConwayIncompleteWithdrawals _) = mconcat [ "todo" .= String "todo"] | |
| toObject _ (Conway.ConwayWithdrawalsMissingAccounts missingWithdrawals) = | |
| mconcat [ "kind" .= String "ConwayWithdrawalsMissingAccounts" | |
| , "withdrawals" .= unWithdrawals missingWithdrawals | |
| ] | |
| toObject _ (Conway.ConwayIncompleteWithdrawals incompleteWithdrawals) = | |
| mconcat [ "kind" .= String "ConwayIncompleteWithdrawals" | |
| , "withdrawals" .= unWithdrawals incompleteWithdrawals | |
| ] |
ana-pantilie
force-pushed
the
ana/10.6-final-integration-mix
branch
from
4d56bc9 to
0960b09
Compare
jasagredo
force-pushed
the
js/lsm
branch
4 times, most recently
from
a462347 to
b3d7412
Compare
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.