add number_format_ja(Japan Format) for number_format

[kusanaginoturugi]

Pull Request Checklist

Please check the following steps before submitting your PR. If any items are incomplete, consider marking it as [WIP] (Work in Progress).

Checklist

• My code follows the code formatting guidelines.
• I have tested my changes locally.
• I selected the appropriate branch for this PR.
• I have rebased my changes on top of the selected branch.
• I included relevant documentation updates if necessary.
• I have an accompanying issue ID for this pull request.

---

Description

Provide a brief description of the changes made in this pull request.

---

Related Issue(s)

List any related issues or discussions. If applicable, link to an accompanying thread on the forums.
Fixes # (example)

---

Motivation and Context

Why was this change necessary? Does it solve a problem or improve an existing feature? If this PR fixes an open issue, link to it here.

---

Issue Type (Check one or more)

• Bugfix
• Improvement of an existing feature
• New feature

---

Screenshots (If Applicable)

Attach relevant screenshots that demonstrate your changes.

---

Thank you for your contribution to InvoicePlane! We appreciate your time and effort.

Summary by CodeRabbit

Release Notes

• New Features
  • Added Japanese number format option to the number formatting configuration, enabling localized display of numbers according to Japanese standards.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6a3f3187-a1a0-4b43-a741-afabf1a48992

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

A new Japanese number format configuration has been added to the application's number formats settings. The configuration introduces a new public entry with label "number_format_ja" and comma thousands separator without modifying existing format definitions.

Changes

Cohort / File(s)	Summary
Japanese Number Format Configuration application/config/number_formats.php	Added new public configuration entry number_format_ja with label and thousands separator (,) for Japanese locale support.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A carrot-colored config line,
With commas neat and format fine,
Japanese numbers now align,
In CodeRabbit's garden divine! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'add number_format_ja(Japan Format) for number_format' clearly and specifically describes the main change - adding a new Japanese number format configuration option.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@application/config/number_formats.php`:
- Around line 53-56: The new number_format_ja array entry is missing the
required 'decimal_point' key so code in Settings.php that does
$number_formats[$value]['decimal_point'] will throw an undefined index error;
update the 'number_format_ja' configuration (the 'number_format_ja' array) to
include a 'decimal_point' key with an explicit value (for example '.' or an
empty string if you prefer no decimals) so the lookup in Settings.php and any
consumers of $number_formats always find the key.
- Around line 53-56: Add a translation entry for the new config key
'number_format_ja' so the settings dropdown (which uses _trans($value['label']))
shows a human-friendly label; update the language files to include a mapping for
'number_format_ja' following the existing pattern used by other number formats
(e.g., the same style as other entries in the language arrays) so the label is
translated instead of showing the raw key.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 359d5ef1-4843-4612-9924-aac1b412c1e7

📥 Commits

Reviewing files that changed from the base of the PR and between ff3c5af and 45d53ca.

📒 Files selected for processing (1)

• application/config/number_formats.php

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Missing decimal_point key will cause runtime error.

The new number_format_ja entry is missing the decimal_point key that all other format entries have. When this format is selected, application/modules/settings/controllers/Settings.php (lines 101-105) directly accesses $number_formats[$value]['decimal_point'] without an isset() check, which will cause an "Undefined index" error.

Even if Japanese Yen doesn't use decimals, a value must be provided for the application to function correctly.

🐛 Proposed fix to add the missing decimal_point key

     'number_format_ja' => [
         'label'               => 'number_format_ja',
+        'decimal_point'       => '.',
         'thousands_separator' => ',',
     ],

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@application/config/number_formats.php` around lines 53 - 56, The new
number_format_ja array entry is missing the required 'decimal_point' key so code
in Settings.php that does $number_formats[$value]['decimal_point'] will throw an
undefined index error; update the 'number_format_ja' configuration (the
'number_format_ja' array) to include a 'decimal_point' key with an explicit
value (for example '.' or an empty string if you prefer no decimals) so the
lookup in Settings.php and any consumers of $number_formats always find the key.

---

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Search for number_format_ja translation key in language files

# Search for the translation key in all language files
rg -n "number_format_ja" --glob "*_lang.php"

Repository: InvoicePlane/InvoicePlane

Length of output: 51

---

🏁 Script executed:

# Check if number_format_ja is referenced/used anywhere in the codebase
rg -n "number_format_ja" --type php --type html

Repository: InvoicePlane/InvoicePlane

Length of output: 231

---

🏁 Script executed:

# Examine the referenced language file to see the existing format translations
head -400 application/language/english/ip_lang.php | tail -30

Repository: InvoicePlane/InvoicePlane

Length of output: 2641

---

🏁 Script executed:

# Search for how number_format labels are used in views/templates
rg -n "number_format" --glob "*.html" --glob "*.php" -A 2 | head -50

Repository: InvoicePlane/InvoicePlane

Length of output: 5585

---

Add missing translation key for the new number format.

The label 'number_format_ja' lacks a corresponding translation entry in the language files. When displayed in the settings dropdown (via _trans($value['label']) at application/modules/settings/views/partial_settings_general.php:217), it will show the raw key "number_format_ja" instead of a human-readable label. Follow the existing pattern from other number formats:

'number_format_ja' => '1,000,000 (Japanese format)',

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@application/config/number_formats.php` around lines 53 - 56, Add a
translation entry for the new config key 'number_format_ja' so the settings
dropdown (which uses _trans($value['label'])) shows a human-friendly label;
update the language files to include a mapping for 'number_format_ja' following
the existing pattern used by other number formats (e.g., the same style as other
entries in the language arrays) so the label is translated instead of showing
the raw key.

[Copilot]

Pull request overview

This PR adds a Japanese number format option (1,000,000 — no decimal places) to InvoicePlane's number format configuration. It also includes an unrelated fix to the release workflow's language directory check and removes an old analysis document.

Changes:

• Added number_format_ja entry to the number formats config
• Updated the release workflow to check application/language/english instead of resources/lang/en
• Deleted the .junie/PR-1441-security-dry-analysis.md document

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

File	Description
application/config/number_formats.php	Adds Japanese number format with thousands separator but missing decimal_point key
.github/workflows/release.yml	Fixes language directory path check from Laravel-style to CodeIgniter-style path
.junie/PR-1441-security-dry-analysis.md	Removes old security/DRY analysis document for a previous PR

[nielsdrost7]

@kusanaginoturugi thanks for the PR, man!
I'll add those 2 suggestions that coderabbit made, so:

• expect a translation string as well for your translations.
• I'll add something for the "decimal point"

You might want to consider this format:

1,000,000.00

It's the US/UK format.
I don't know of you guys work with decimal points though