Types for TypeScript #19

Activity

1. Janpot commented on Jul 8, 2020

   

   Janpot

   on Jul 8, 2020

   Last edited by Janpot

   Owner

   More actions

   Can you try to enable checkJs in your tsconfig.json? For now the types are strictly internal, I'm not sure I want to introduce a build step at this point.
2. raine commented on Jul 8, 2020

   

   raine

   on Jul 8, 2020

   Author

   More actions

   No effect. I wonder if that setting applies only to project files and not dependencies.
3. raine commented on Jul 8, 2020

   

   raine

   on Jul 8, 2020

   Author

   More actions

   This worked:

   "include": ["node_modules/microdata-node/src/**/*.js"]
   

   Looks like config is incorrectly defined as required parameter to toJson. It's optional in README.

   scripts/run.ts:21:39 - error TS2554: Expected 2 arguments, but got 1.
   
   21     require('util').inspect(microdata.toJson(html), {
                                            ~~~~~~~~~~~~~~~~~~
   
     node_modules/microdata-node/src/index.js:59:33
       59 function toJson (microdataHtml, config) {
                                          ~~~~~~
       An argument for 'config' was not provided.