Skip to content

Fix: make notebook commands cross-platform and minimize unnecessary changes#500

Open
shardulmahamulkar wants to merge 2 commits intoJdeRobot:masterfrom
shardulmahamulkar:fix/cross-platform-mkdir
Open

Fix: make notebook commands cross-platform and minimize unnecessary changes#500
shardulmahamulkar wants to merge 2 commits intoJdeRobot:masterfrom
shardulmahamulkar:fix/cross-platform-mkdir

Conversation

@shardulmahamulkar
Copy link
Copy Markdown

This PR updates the notebook to improve cross-platform compatibility while keeping the changes minimal and focused.

Changes

  • Replaced Linux-specific mkdir -p commands with os.makedirs() for cross-platform support
  • Adjusted !gdown command usage to avoid issues on Windows
  • Updated only the relevant notebook cell as requested

Notes

  • Avoided modifying outputs or unrelated notebook metadata to keep the diff minimal and review-friendly
  • This PR updates the previous submission based on review feedback to keep the diff minimal and focused.

Closes #463

@dpascualhe
Copy link
Copy Markdown
Collaborator

Looking good! Resolve the conflicts with the master branch and we'll merge then

@shardulmahamulkar
Copy link
Copy Markdown
Author

Thanks! I’ve resolved the conflicts with the latest master and pushed the changes. Let me know if everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux-specific mkdir syntax in example notebooks breaks on Windows

2 participants