Repository navigation
Fix jlab.decodeRange's fiscal Q3 ranges on the 31st of a month - #84
Merged
Merged
Conversation
The fiscal cases set the month before the day. On the 31st, setting April, which has 30 days, rolled into May 1, so this and last fiscal year's Q3 started on May 1 and ended on August 1. They now set the day to the 1st first. Only Q3 was wrong, since the other quarters and the fiscal year start in 31-day months, but every fiscal case now sets the day first, so they read the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slominskir
approved these changes
Oct 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
jlab.decodeRangeinsmoothness.js: on the 31st of any month,0fiscalyearq3and1fiscalyearq3started on May 1 and ended on August 1, instead of April 1 to July 1. The fiscal cases set the month before the day, and April 31 rolls into May 1. They now set the day to the 1st first. Only Q3 was wrong (October, January, and July have 31 days), but all ten fiscal cases now set the day first. This bug is in 5.2.0 too; the Java side (TimeUtil) adds months to the fiscal year's start and was right.SmoothnessJsIT.decodeRangeOnTheThirtyFirst: decodes every fiscal range with the browser's clock fixed on Saturday 2026-10-31.Compatibility
A bug fix in a public function; apps need no step, and they get it when they upgrade the weblib.
Checks
01-May-2027and01-May-2026where April 1 was expected)../gradlew buildpassed../gradlew integrationTestran 117 tests, none failed or skipped. The demo's log has no errors.🤖 Generated with Claude Code