Add size property to types that conform to Location#117
Open
tonyarnold wants to merge 3 commits intoJohnSundell:masterfrom
Open
Add size property to types that conform to Location#117tonyarnold wants to merge 3 commits intoJohnSundell:masterfrom
size property to types that conform to Location#117tonyarnold wants to merge 3 commits intoJohnSundell:masterfrom
Conversation
|
Any News about merging this changes? |
|
@tonyarnold Please if you could also add the ability to calculate the total size of a folder like this https://stackoverflow.com/a/16139991/8742572 I would be grateful because I have no idea about writing tests 😅. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resurrects the changes proposed by @Gruppio in #65.