Repository navigation
Support passphrase and ssl_ca with ssl_capath - #263
Merged
Merged
Conversation
passphrase unlocks an encrypted ssl_key, and ssl_ca and ssl_capath are trusted together, now that Reseau 1.7 exposes key_passphrase and ca_dir. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
quinnj
approved these changes
Nov 16, 2026
quinnj
left a comment
Member
There was a problem hiding this comment.
Approving. passphrase unlocks an encrypted client key, and ssl_ca with ssl_capath are trusted together. An independent review checked:
- the positional
Reseau.TLS.Configarguments against Reseau 1.7.0 - that the passphrase never appears in
showor error output - the trim build
- behavior manifest row 180 against mysql:8.4
The full suite passed locally (1917/1917), and CI is green.
[review generated via AI]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two TLS settings that Connector/C users rely on are rejected today:
passphraseraises "not available in MySQL.jl 2.0", so a client certificate with an encrypted private key cannot be used.ssl_caandssl_capathtogether raise anArgumentError, because Reseau used to take only one trust source.Reseau now supports both. Reseau 1.7.0 added
key_passphrase(JuliaServices/Reseau.jl#240), andca_diris trusted together withca_file(JuliaServices/Reseau.jl#164).Change
passphraseunlocks an encryptedssl_key. It is stored inTLSOptions.key_passphraseand passed to Reseau'sTLS.Config.showforTLSOptionsprints"…"in its place, andConnectOptionsnever printed TLS details.ssl_caandssl_capath, the bundle and the directory are trusted together. Either one alone works as before.tls_configchain narrows the passphrase and the CA directory to concrete types before its single positionalConfigcall, as it already did for the other optional settings.1.7.passphrase. The migration guide no longer listspassphraseas unavailable and showsssl_ca+ssl_capathas applied together.TLSNegotiationError. With both settings honored, its nonexistent paths fail the TLS handshake instead of failing option validation.Verification
New fake-peer tests in
test/protocol/tls_tests.jl:client-encrypted.key(PKCS#8, AES-256-CBC) with the right passphrase. With a wrong passphrase, or none, the connection fails withTLSNegotiationError.ssl_canaming an unrelated root andssl_capathholding the server's CA,:verify_casucceeds. The samessl_caalone fails, so the directory is what made it pass.test/protocol/native_tests.jlchecks the parsed options and thatshowdoes not reveal the passphrase.certs/gen.shregenerates the encrypted key.🤖 Generated with Claude Code