Repository navigation
Count only the vcat specializations a splat adds in the concatenation test - #1171
Merged
Merged
Conversation
…on test The method of `vcat` for numbers takes every `Number` eltype, and other suites run first in the same worker, so the count of its specializations reached the bound when `test/solvers/issues.jl` concatenated `Int`s before `test/concatenation.jl` ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 16 16
Lines 10748 10748
=======================================
Hits 10638 10638
Misses 110 110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ViralBShah
added a commit
that referenced
this pull request
Nov 13, 2026
- [x] #1167 - [x] #1169 - [x] #1166 - [x] #1165 - [x] #1161 - [x] #1168 - [x] #1163 - [x] #1171 - [x] #1143 - [x] #1164 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Stefan Karpinski <stefan@karpinski.org> Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The splatted-
vcatcheck that #1160 added totest/concatenation.jlfails in comprehensive mode whentest/solvers/issues.jlruns before it in the same worker, which ParallelTestRunner does on some runs. It failed that way on #1170.Before, running the two suites in that order in one process on
main:After: it passes in that order, and alone.
The check counts every specialization of
vcat(n1::N, ns::N...) where N<:Number, which takes everyNumbereltype, so it counts what earlier suites compiled too.test/solvers/issues.jlconcatenatesInts, which compilesTuple{typeof(vcat), Vararg{Int64, 4}}andTuple{typeof(vcat), Int64, Int64, Int64, Vararg{Int64}}. The splats of 50 to 60Float64s add three specializations, so the total reaches the bound. The test now counts only the specializations the splats add. A method compiled once for every length would add 11, so the bound still catches the regression #1160 fixed. The code is unchanged.To be backported to 1.14 in #1170.
Written by Claude Code.
🤖 Generated with Claude Code