C# Client: 送信時のレースコンディションを解消 - #98
Open
makiuchi-d wants to merge 5 commits into
Open
Conversation
methane
reviewed
Aug 26, 2026
| { | ||
| ClientWebSocket client; | ||
| SemaphoreSlim sendSemaphore; | ||
| bool closed; |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
ありがとうございます
volatileつけました
There was a problem hiding this comment.
Pull request overview
WebSocket再接続時の送信競合を抑制する変更です。
Changes:
- キャンセル済みSenderによるメッセージ取得を抑制
- 接続単位で送信Semaphoreと切断状態を管理
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
MsgPool.cs |
キャンセル検出可能な待機処理へ変更 |
Connection.cs |
WebSocket接続ごとの送信状態と同期処理を導入 |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+444
to
+446
| if (ct.IsCancellationRequested) | ||
| { | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
クライアントメッセージのHMACが一致しないことがあるのを発見
websocket再接続の前後でのレースコンディションにより、送信バッファが別タスクから書き換えられる可能性があった
修正内容：
挙動の変更：
NetworkInformer.OnRoomSend()呼び出しタイミングが変更になり、切断後の送信も呼び出されるようになった
もともとこの機能はデバッグ時の計測用途のため影響は軽微（Conditional("DEBUG")が指定されている）